Commit 5912897
committed
Guard the JSC unhandled-rejection SPI to Apple platforms
The macOS CI matrix built fine, but the Linux JSC job (WebKitGTK via gcc) failed:
JSGlobalContextSetUnhandledRejectionCallback is an Apple SPI absent from WebKitGTK,
and __builtin_available / its iOS/macOS platform names are Clang/Apple-only, so the
unguarded registration didn't compile under gcc.
- AppRuntime_JavaScriptCore.cpp: wrap the rejection-callback machinery (forward
declaration, thread_local context, callback, and registration) in #if __APPLE__.
On non-Apple JSC (WebKitGTK/Linux, Android JSC) tracking is now a documented no-op,
consistent with the existing #if __APPLE__ guard around JSGlobalContextSetInspectable.
- Shared.cpp: tighten the compile-time gate to
V8 || (JavaScriptCore && __APPLE__), so the rejection tests skip on non-Apple JSC
where the hook is unavailable (otherwise they would hang waiting for a report).
- AppRuntime.h: note that JSC support is Apple-only (WebKitGTK JSC is a no-op).
Re-validated on Win32 V8 Release: AppRuntime rejection tests pass.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 2eef639 commit 5912897
3 files changed
Lines changed: 24 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
56 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | 2 | | |
4 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| 13 | + | |
| 14 | + | |
11 | 15 | | |
| 16 | + | |
12 | 17 | | |
13 | 18 | | |
14 | 19 | | |
| 20 | + | |
15 | 21 | | |
16 | 22 | | |
17 | 23 | | |
| |||
43 | 49 | | |
44 | 50 | | |
45 | 51 | | |
| 52 | + | |
46 | 53 | | |
47 | 54 | | |
48 | 55 | | |
| |||
57 | 64 | | |
58 | 65 | | |
59 | 66 | | |
| 67 | + | |
60 | 68 | | |
61 | 69 | | |
62 | 70 | | |
| |||
67 | 75 | | |
68 | 76 | | |
69 | 77 | | |
| 78 | + | |
70 | 79 | | |
71 | 80 | | |
72 | 81 | | |
| 82 | + | |
73 | 83 | | |
| 84 | + | |
74 | 85 | | |
75 | 86 | | |
76 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
283 | 283 | | |
284 | 284 | | |
285 | 285 | | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
291 | 292 | | |
292 | 293 | | |
293 | 294 | | |
| |||
313 | 314 | | |
314 | 315 | | |
315 | 316 | | |
316 | | - | |
317 | | - | |
| 317 | + | |
| 318 | + | |
318 | 319 | | |
319 | 320 | | |
320 | 321 | | |
| |||
0 commit comments