Commit 81b01d2
Add TextEncoder polyfill (WHATWG Encoding Standard) (#171)
Adds a `TextEncoder` polyfill that mirrors the existing `TextDecoder`
polyfill in this repository, so non-Babylon-Native consumers can get
both halves of the [WHATWG Encoding
Standard](https://encoding.spec.whatwg.org/) from `JsRuntimeHost`
without having to pull in or duplicate a separate implementation.
`TextEncoder` is needed by older Chakra-based runtimes where the global
is not built in. Modern V8 / JSC / Hermes runtimes already expose it
natively, in which case `Initialize()` is a no-op.
## Surface
- `TextEncoder()` constructor — UTF-8 only, per spec
- `encoding` accessor — always `"utf-8"`
- `encode(input)` → `Uint8Array`
- `encodeInto(source, destination)` → `{ read, written }`
- `read` is in UTF-16 code units, so a 4-byte UTF-8 sequence (code point
outside the BMP) reports `2`
- Multi-byte UTF-8 sequences are never split across the destination
boundary
## Build / wiring
- New gated option `JSRUNTIMEHOST_POLYFILL_TEXTENCODER` (default `ON`),
matching the pattern used by every other polyfill in this repo.
- New `Polyfills/TextEncoder/` library with the same layout as
`Polyfills/TextDecoder/` (`CMakeLists.txt`,
`Include/Babylon/Polyfills/TextEncoder.h`, `Source/TextEncoder.cpp`,
`README.md`).
- Linked into the unit-test executable (Windows + Android) and
initialized in `Tests/UnitTests/Shared/Shared.cpp` next to
`TextDecoder::Initialize`.
## Tests
Adds a new `describe("TextEncoder", ...)` block in
`Tests/UnitTests/Scripts/tests.ts` covering:
- `encoding === "utf-8"`
- `encode()` on ASCII, undefined / no-arg, multi-byte UTF-8 (e.g. `"é"`
→ `[0xC3, 0xA9]`), and embedded null bytes
- `encodeInto()` happy path, refusal to split a multi-byte sequence when
the destination is too small, and the surrogate-pair `read` semantics
for `U+1F600`
- `encodeInto()` `TypeError` when the destination is not a `Uint8Array`
## Motivation
Surfaced during the BabylonNative review of
[BabylonJS/BabylonNative#1708](BabylonJS/BabylonNative#1708),
where this polyfill originally lived. Per @bghgary's review feedback,
`TextEncoder` belongs alongside `TextDecoder` in JsRuntimeHost so it's
available to any consumer of this runtime host, not just BN.
---------
Co-authored-by: Branimir Karadžić (via Copilot) <223556219+Copilot@users.noreply.github.com>1 parent 1e9b17e commit 81b01d2
10 files changed
Lines changed: 171 additions & 0 deletions
File tree
- Polyfills
- TextEncoder
- Include/Babylon/Polyfills
- Source
- Tests/UnitTests
- Android/app/src/main/cpp
- Scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
| 85 | + | |
85 | 86 | | |
86 | 87 | | |
87 | 88 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
35 | 39 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
45 | 46 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1356 | 1356 | | |
1357 | 1357 | | |
1358 | 1358 | | |
| 1359 | + | |
| 1360 | + | |
| 1361 | + | |
| 1362 | + | |
| 1363 | + | |
| 1364 | + | |
| 1365 | + | |
| 1366 | + | |
| 1367 | + | |
| 1368 | + | |
| 1369 | + | |
| 1370 | + | |
| 1371 | + | |
| 1372 | + | |
| 1373 | + | |
| 1374 | + | |
| 1375 | + | |
| 1376 | + | |
| 1377 | + | |
| 1378 | + | |
| 1379 | + | |
| 1380 | + | |
| 1381 | + | |
| 1382 | + | |
| 1383 | + | |
| 1384 | + | |
| 1385 | + | |
| 1386 | + | |
| 1387 | + | |
| 1388 | + | |
| 1389 | + | |
| 1390 | + | |
| 1391 | + | |
| 1392 | + | |
| 1393 | + | |
| 1394 | + | |
| 1395 | + | |
| 1396 | + | |
1359 | 1397 | | |
1360 | 1398 | | |
1361 | 1399 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
83 | 84 | | |
84 | 85 | | |
85 | 86 | | |
| 87 | + | |
86 | 88 | | |
87 | 89 | | |
88 | 90 | | |
| |||
0 commit comments