test(e2e): reuse shared failing server in async fallback test

Author: jkyberneees

test/e2e/hooks.test.ts

@@ -631,38 +631,7 @@ describe('Hooks E2E Tests', () => {
   }, 20000)
 
   test('should handle async fallback response generation', async () => {
-    // Create a new failing server for this test
-    const asyncFailingPort = Math.floor(Math.random() * 10000) + 56000
-    const asyncFailingServer = Bun.serve({
-      port: asyncFailingPort,
-      fetch: async (req) => {
-        const url = new URL(req.url)
-        if (url.pathname === '/error') {
-          return new Response('Server error', { status: 500 })
-        }
-        return new Response('OK', { status: 200 })
-      },
-    } as Parameters<typeof Bun.serve>[0])
-
-    // Wait for the failing server to be ready (allow extra time for slow CI runners)
-    let failingServerReady = false
-    for (let i = 0; i < 100; i++) {
-      try {
-        const healthCheck = await fetch(`http://localhost:${asyncFailingPort}/`)
-        if (healthCheck.status === 200) {
-          failingServerReady = true
-          break
-        }
-      } catch {
-        await new Promise((resolve) => setTimeout(resolve, 50))
-      }
-    }
-    if (!failingServerReady) {
-      asyncFailingServer.stop()
-      throw new Error('Failing server failed to start')
-    }
-
-    // Create a new gateway with async onError hook
+    // Reuse the shared failing server so we do not re-flake on CI server startup
     const asyncGatewayPort = Math.floor(Math.random() * 10000) + 53000
     const asyncGateway = new BunGateway({
       server: {
@@ -674,7 +643,7 @@ describe('Hooks E2E Tests', () => {
 
     const asyncRouteConfig: RouteConfig = {
       pattern: '/api/async-fallback/*',
-      target: `http://localhost:${asyncFailingPort}`,
+      target: `http://localhost:${failingPort}`,
       timeout: 5000,
       proxy: {
         pathRewrite: {
@@ -728,7 +697,6 @@ describe('Hooks E2E Tests', () => {
     }
     if (!gatewayReady) {
       asyncServer.stop()
-      asyncFailingServer.stop()
       throw new Error('Gateway server failed to start')
     }
 
@@ -755,7 +723,6 @@ describe('Hooks E2E Tests', () => {
       )
     } finally {
       asyncServer.stop()
-      asyncFailingServer.stop()
     }
   }, 30000)
 })