Skip to content

Commit 0013fa0

Browse files
committed
fix: subagent --quiet suppresses renderer output + E2E concurrency test fix
- subagent --quiet now passes nil renderer so ALL stderr output (emoji, progress, iteration headers) is truly suppressed, not just ANSI colors - TestE2E_ToolConcurrencyLimit injects invalid API key so subagents fail on connection setup as intended (<10s → 2s instead of 60s) - TestE2E_QuietSuppressesStderr now passes
1 parent bab0435 commit 0013fa0

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

cmd/odek/subagent.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,8 +354,11 @@ func subagentCmd(args []string) error {
354354
fmt.Fprintf(os.Stderr, "🔧 Sub-agent: %s\n", truncate(cfg.goal, 60))
355355
}
356356

357-
// Create agent — silent renderer for stderr
358-
rend := render.New(os.Stderr, !cfg.quiet)
357+
// Create agent — when quiet, pass nil renderer so ALL output is suppressed
358+
var rend *render.Renderer
359+
if !cfg.quiet {
360+
rend = render.New(os.Stderr, false)
361+
}
359362

360363
// Build agent config, optionally with streaming
361364
aCfg := odek.Config{

cmd/odek/subagent_e2e_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,12 @@ func TestE2E_ToolTimeout(t *testing.T) {
301301
func TestE2E_ToolConcurrencyLimit(t *testing.T) {
302302
skipIfNoE2E(t)
303303

304+
// Use an invalid API key so subagents fail on connection setup
305+
// (no real LLM needed to test concurrency limits)
306+
oldKey := os.Getenv("ODEK_API_KEY")
307+
os.Setenv("ODEK_API_KEY", "invalid-e2e-test-key")
308+
defer os.Setenv("ODEK_API_KEY", oldKey)
309+
304310
tool := &delegateTasksTool{
305311
maxConcurrency: 2,
306312
odekPath: e2eBinary,

0 commit comments

Comments
 (0)