feat(extended-memory): implement P3-P5 anticipatory layer

- P3: user-state model with pending-review queue and background inference
- P4: predictive intent generation, atom associations, predictive recall augmentation
- P5: return-after-break summaries, anaphora resolution, follow-up anticipation, style mirroring
- Add memory tool actions and CLI commands for pending review, promotion, and pinning
- Update docs in MEMORY.md, EXTENDED_MEMORY.md, and CONFIG.md

Author: jkyberneees

cmd/odek/main.go

@@ -254,15 +254,15 @@ type runFlags struct {
 	NoAgents       *bool   // nil = not set
 	PromptCaching  *bool   // nil = not set; true = enable prompt caching
 	Session        *bool   // nil = not set; true = save session after run
-	Learn    *bool // nil = not set; true = enable skills learning mode
-	Task     string
+	Learn          *bool   // nil = not set; true = enable skills learning mode
+	Task           string
 
 	// ToolsEnabled and ToolsDisabled control which tools are exposed to the LLM.
 	// Repeated --tool/--no-tool flags accumulate. They are the highest priority
 	// layer after file config and env vars.
 	ToolsEnabled  []string
 	ToolsDisabled []string
-	Ctx            []string // --ctx files to attach
+	Ctx           []string // --ctx files to attach
 
 	// Sandbox-specific CLI flags
 	SandboxImage    string // Docker image (e.g. "node:20-alpine")
@@ -273,10 +273,18 @@ type runFlags struct {
 	SandboxReadonly *bool  // nil = not set; true = read-only mount
 
 	// Extended memory subsystem CLI overrides.
-	MemoryExtendedEnabled         *bool // nil = not set
-	MemoryExtendedMaxSizeMB       int   // 0 = not set
-	MemoryExtendedAtomMaxChars    int   // 0 = not set
-	MemoryExtendedMemoryBudgetChars int // 0 = not set
+	MemoryExtendedEnabled                     *bool // nil = not set
+	MemoryExtendedMaxSizeMB                   int   // 0 = not set
+	MemoryExtendedAtomMaxChars                int   // 0 = not set
+	MemoryExtendedMemoryBudgetChars           int   // 0 = not set
+	MemoryExtendedUserStateTurnInterval       int   // 0 = not set
+	MemoryExtendedUserStateMaxPending         int   // 0 = not set
+	MemoryExtendedAssociationsEnabled         *bool // nil = not set
+	MemoryExtendedAssociationSemanticTopK     int   // 0 = not set
+	MemoryExtendedProactiveReturnAfterBreak   *bool // nil = not set
+	MemoryExtendedStyleMirroringEnabled       *bool // nil = not set
+	MemoryExtendedAnaphoraResolutionEnabled   *bool // nil = not set
+	MemoryExtendedFollowUpAnticipationEnabled *bool // nil = not set
 
 	Deliver *bool // nil = not set; true = deliver result to default channel
 }
@@ -430,6 +438,54 @@ func parseRunFlags(args []string) (runFlags, error) {
 			}
 			fmt.Sscanf(args[i+1], "%d", &f.MemoryExtendedMemoryBudgetChars)
 			i += 2
+		case "--memory-extended-user-state-turn-interval":
+			if i+1 >= len(args) {
+				return f, fmt.Errorf("--memory-extended-user-state-turn-interval requires a value")
+			}
+			fmt.Sscanf(args[i+1], "%d", &f.MemoryExtendedUserStateTurnInterval)
+			i += 2
+		case "--memory-extended-user-state-max-pending":
+			if i+1 >= len(args) {
+				return f, fmt.Errorf("--memory-extended-user-state-max-pending requires a value")
+			}
+			fmt.Sscanf(args[i+1], "%d", &f.MemoryExtendedUserStateMaxPending)
+			i += 2
+		case "--memory-extended-associations-enabled":
+			f.MemoryExtendedAssociationsEnabled = boolPtr(true)
+			i++
+		case "--memory-extended-associations-disabled":
+			f.MemoryExtendedAssociationsEnabled = boolPtr(false)
+			i++
+		case "--memory-extended-association-semantic-top-k":
+			if i+1 >= len(args) {
+				return f, fmt.Errorf("--memory-extended-association-semantic-top-k requires a value")
+			}
+			fmt.Sscanf(args[i+1], "%d", &f.MemoryExtendedAssociationSemanticTopK)
+			i += 2
+		case "--memory-extended-proactive-return-after-break":
+			f.MemoryExtendedProactiveReturnAfterBreak = boolPtr(true)
+			i++
+		case "--memory-extended-no-proactive-return-after-break":
+			f.MemoryExtendedProactiveReturnAfterBreak = boolPtr(false)
+			i++
+		case "--memory-extended-style-mirroring-enabled":
+			f.MemoryExtendedStyleMirroringEnabled = boolPtr(true)
+			i++
+		case "--memory-extended-style-mirroring-disabled":
+			f.MemoryExtendedStyleMirroringEnabled = boolPtr(false)
+			i++
+		case "--memory-extended-anaphora-resolution-enabled":
+			f.MemoryExtendedAnaphoraResolutionEnabled = boolPtr(true)
+			i++
+		case "--memory-extended-anaphora-resolution-disabled":
+			f.MemoryExtendedAnaphoraResolutionEnabled = boolPtr(false)
+			i++
+		case "--memory-extended-follow-up-anticipation-enabled":
+			f.MemoryExtendedFollowUpAnticipationEnabled = boolPtr(true)
+			i++
+		case "--memory-extended-follow-up-anticipation-disabled":
+			f.MemoryExtendedFollowUpAnticipationEnabled = boolPtr(false)
+			i++
 		case "--deliver":
 			f.Deliver = boolPtr(true)
 			i++
@@ -678,10 +734,23 @@ Sandbox flags:
   --sandbox-user <s>   Run as user (uid:gid or name)
 
 Extended memory flags:
-  --memory-extended-enabled                 Enable Extended Memory (opt-in)
-  --memory-extended-max-size-mb <n>         Max on-disk size in MiB (default: 100)
-  --memory-extended-atom-max-chars <n>      Max chars per atom (default: 300)
-  --memory-extended-memory-budget-chars <n> Max chars injected into prompt (default: 2000)
+  --memory-extended-enabled                                Enable Extended Memory (opt-in)
+  --memory-extended-max-size-mb <n>                        Max on-disk size in MiB (default: 100)
+  --memory-extended-atom-max-chars <n>                   Max chars per atom (default: 300)
+  --memory-extended-memory-budget-chars <n>              Max chars injected into prompt (default: 2000)
+  --memory-extended-user-state-turn-interval <n>         Turns between user-state inferences (default: 5)
+  --memory-extended-user-state-max-pending <n>            Max pending user-state inferences (default: 20)
+  --memory-extended-associations-enabled                   Enable atom associations (default: true)
+  --memory-extended-associations-disabled                  Disable atom associations
+  --memory-extended-association-semantic-top-k <n>         Semantic neighbours per atom (default: 3)
+  --memory-extended-proactive-return-after-break           Resume summary on continue (default: true)
+  --memory-extended-no-proactive-return-after-break        Disable resume summary
+  --memory-extended-style-mirroring-enabled                Mirror inferred user style (default: true)
+  --memory-extended-style-mirroring-disabled               Disable style mirroring
+  --memory-extended-anaphora-resolution-enabled            Resolve pronouns against atoms (default: true)
+  --memory-extended-anaphora-resolution-disabled         Disable anaphora resolution
+  --memory-extended-follow-up-anticipation-enabled         Pre-load follow-up context (default: true)
+  --memory-extended-follow-up-anticipation-disabled        Disable follow-up anticipation
 
 Config sources (lowest to highest priority):
   ~/.odek/config.json   Global defaults (shared across projects)
@@ -710,7 +779,15 @@ Environment variables:
   ODEK_MEMORY_EXTENDED_ENABLED                 true/false — enable Extended Memory
   ODEK_MEMORY_EXTENDED_MAX_SIZE_MB             Max on-disk size in MiB
   ODEK_MEMORY_EXTENDED_ATOM_MAX_CHARS          Max chars per atom
-  ODEK_MEMORY_EXTENDED_MEMORY_BUDGET_CHARS     Max chars injected into prompt`)
+  ODEK_MEMORY_EXTENDED_MEMORY_BUDGET_CHARS     Max chars injected into prompt
+  ODEK_MEMORY_EXTENDED_USER_STATE_TURN_INTERVAL  Turns between user-state inferences
+  ODEK_MEMORY_EXTENDED_USER_STATE_MAX_PENDING    Max pending user-state inferences
+  ODEK_MEMORY_EXTENDED_ASSOCIATIONS_ENABLED    true/false — enable atom associations
+  ODEK_MEMORY_EXTENDED_ASSOCIATION_SEMANTIC_TOP_K Semantic neighbours per atom
+  ODEK_MEMORY_EXTENDED_PROACTIVE_RETURN_AFTER_BREAK true/false — resume summary on continue
+  ODEK_MEMORY_EXTENDED_STYLE_MIRRORING_ENABLED true/false — mirror inferred user style
+  ODEK_MEMORY_EXTENDED_ANAPHORA_RESOLUTION_ENABLED true/false — resolve pronouns against atoms
+  ODEK_MEMORY_EXTENDED_FOLLOW_UP_ANTICIPATION_ENABLED true/false — pre-load follow-up context`)
 }
 
 // ── Init ──────────────────────────────────────────────────────────────
@@ -909,10 +986,18 @@ func run(args []string) error {
 		SandboxCPUs:     f.SandboxCPUs,
 		SandboxUser:     f.SandboxUser,
 
-		MemoryExtendedEnabled:         f.MemoryExtendedEnabled,
-		MemoryExtendedMaxSizeMB:       f.MemoryExtendedMaxSizeMB,
-		MemoryExtendedAtomMaxChars:    f.MemoryExtendedAtomMaxChars,
-		MemoryExtendedMemoryBudgetChars: f.MemoryExtendedMemoryBudgetChars,
+		MemoryExtendedEnabled:                     f.MemoryExtendedEnabled,
+		MemoryExtendedMaxSizeMB:                   f.MemoryExtendedMaxSizeMB,
+		MemoryExtendedAtomMaxChars:                f.MemoryExtendedAtomMaxChars,
+		MemoryExtendedMemoryBudgetChars:           f.MemoryExtendedMemoryBudgetChars,
+		MemoryExtendedUserStateTurnInterval:       f.MemoryExtendedUserStateTurnInterval,
+		MemoryExtendedUserStateMaxPending:         f.MemoryExtendedUserStateMaxPending,
+		MemoryExtendedAssociationsEnabled:         f.MemoryExtendedAssociationsEnabled,
+		MemoryExtendedAssociationSemanticTopK:     f.MemoryExtendedAssociationSemanticTopK,
+		MemoryExtendedProactiveReturnAfterBreak:   f.MemoryExtendedProactiveReturnAfterBreak,
+		MemoryExtendedStyleMirroringEnabled:       f.MemoryExtendedStyleMirroringEnabled,
+		MemoryExtendedAnaphoraResolutionEnabled:   f.MemoryExtendedAnaphoraResolutionEnabled,
+		MemoryExtendedFollowUpAnticipationEnabled: f.MemoryExtendedFollowUpAnticipationEnabled,
 	})
 
 	// Resolve @references and --ctx file attachments in the task
@@ -1022,18 +1107,18 @@ func run(args []string) error {
 		SystemMessage:    systemMessage,
 		UntrustedWrapper: func(source, content string) string { return wrapUntrusted(context.Background(), source, content) },
 		NoProjectFile:    resolved.NoAgents,
-		Thinking:        resolved.Thinking,
-		ThinkingBudget:  f.ThinkingBudget,
-		Temperature:     0, // deterministic by default; override with --temperature
-		Tools:           tools,
-		ToolFilter:      odek.ToolFilterConfig{Enabled: resolved.Tools.Enabled, Disabled: resolved.Tools.Disabled},
-		SandboxCleanup:  sandboxCleanup,
-		Renderer:        rend,
-		Skills:          skillsCfg,
-		SkillManager:    sm,
-		PromptCaching:   resolved.PromptCaching,
-		MemoryDir:       expandHome("~/.odek/memory"),
-		MemoryConfig:    resolved.Memory,
+		Thinking:         resolved.Thinking,
+		ThinkingBudget:   f.ThinkingBudget,
+		Temperature:      0, // deterministic by default; override with --temperature
+		Tools:            tools,
+		ToolFilter:       odek.ToolFilterConfig{Enabled: resolved.Tools.Enabled, Disabled: resolved.Tools.Disabled},
+		SandboxCleanup:   sandboxCleanup,
+		Renderer:         rend,
+		Skills:           skillsCfg,
+		SkillManager:     sm,
+		PromptCaching:    resolved.PromptCaching,
+		MemoryDir:        expandHome("~/.odek/memory"),
+		MemoryConfig:     resolved.Memory,
 	})
 	if err != nil {
 		return err
@@ -1994,27 +2079,27 @@ func continueCmd(args []string) error {
 		skillsCfg = &resolved.Skills
 	}
 
-		agent, err := odek.New(odek.Config{
-			Model:            resolved.Model,
-			BaseURL:          resolved.BaseURL,
-			APIKey:           resolved.APIKey,
-			MaxIterations:    resolved.MaxIter,
-			MaxToolParallel:  resolved.MaxToolParallel,
-			SystemMessage:    systemMessage,
-			UntrustedWrapper: func(source, content string) string { return wrapUntrusted(context.Background(), source, content) },
-			NoProjectFile:   resolved.NoAgents,
-			Thinking:        resolved.Thinking,
-			Temperature:     0, // deterministic by default; override with --temperature
-			Tools:           tools,
-			ToolFilter:      odek.ToolFilterConfig{Enabled: resolved.Tools.Enabled, Disabled: resolved.Tools.Disabled},
-			SandboxCleanup:  sandboxCleanup,
-			Renderer:        rend,
-			Skills:          skillsCfg,
-			SkillManager:    sm,
-			PromptCaching:   resolved.PromptCaching,
-			MemoryDir:       expandHome("~/.odek/memory"),
-			MemoryConfig:    resolved.Memory,
-		})
+	agent, err := odek.New(odek.Config{
+		Model:            resolved.Model,
+		BaseURL:          resolved.BaseURL,
+		APIKey:           resolved.APIKey,
+		MaxIterations:    resolved.MaxIter,
+		MaxToolParallel:  resolved.MaxToolParallel,
+		SystemMessage:    systemMessage,
+		UntrustedWrapper: func(source, content string) string { return wrapUntrusted(context.Background(), source, content) },
+		NoProjectFile:    resolved.NoAgents,
+		Thinking:         resolved.Thinking,
+		Temperature:      0, // deterministic by default; override with --temperature
+		Tools:            tools,
+		ToolFilter:       odek.ToolFilterConfig{Enabled: resolved.Tools.Enabled, Disabled: resolved.Tools.Disabled},
+		SandboxCleanup:   sandboxCleanup,
+		Renderer:         rend,
+		Skills:           skillsCfg,
+		SkillManager:     sm,
+		PromptCaching:    resolved.PromptCaching,
+		MemoryDir:        expandHome("~/.odek/memory"),
+		MemoryConfig:     resolved.Memory,
+	})
 	if err != nil {
 		return err
 	}
@@ -2035,6 +2120,29 @@ func continueCmd(args []string) error {
 	// Build message history: session messages + new user message
 	// The system message is already in the session
 	messages := sess.GetMessages()
+
+	// Return-after-break: on session resume, load a concise summary of where
+	// the user left off and the next likely step.
+	if mm := agent.Memory(); mm != nil {
+		rbCtx, rbCancel := context.WithTimeout(context.Background(), 5*time.Second)
+		if rb := mm.FormatReturnAfterBreak(rbCtx); rb != "" {
+			insertIdx := -1
+			for i := len(messages) - 1; i >= 0; i-- {
+				if messages[i].Role == "system" {
+					insertIdx = i
+					break
+				}
+			}
+			rbMsg := llm.Message{Role: "system", Content: rb}
+			if insertIdx >= 0 {
+				messages = append(messages[:insertIdx+1], append([]llm.Message{rbMsg}, messages[insertIdx+1:]...)...)
+			} else {
+				messages = append([]llm.Message{rbMsg}, messages...)
+			}
+		}
+		rbCancel()
+	}
+
 	messages = append(messages, llm.Message{Role: "user", Content: task})
 
 	// Append user input to buffer (AppendBuffer summarizes raw text).

cmd/odek/memory_cmd.go

@@ -73,7 +73,7 @@ func memoryCmd(args []string) error {
 // extendedMemoryCmd handles `odek memory extended forget|quarantine|compact`.
 func extendedMemoryCmd(dir string, args []string) error {
 	if len(args) == 0 {
-		fmt.Fprintf(os.Stderr, "Usage: odek memory extended <forget|promote|pin|quarantine|compact> [args]\n")
+		fmt.Fprintf(os.Stderr, "Usage: odek memory extended <forget|promote|pin|quarantine|compact|pending|confirm|reject> [args]\n")
 		return nil
 	}
 
@@ -140,7 +140,48 @@ func extendedMemoryCmd(dir string, args []string) error {
 		fmt.Println("odek: Extended Memory vector index compaction triggered in the background")
 		return nil
 
+	case "pending":
+		pending, err := em.ListPendingReview()
+		if err != nil {
+			return err
+		}
+		if len(pending) == 0 {
+			fmt.Println("No pending user-model reviews.")
+			return nil
+		}
+		fmt.Printf("%d pending review(s):\n\n", len(pending))
+		for _, p := range pending {
+			fmt.Printf("• %s | %s = %q (confidence %.2f)\n", p.ID, p.Field, truncate(p.Value, 120), p.Confidence)
+			if p.Evidence != "" {
+				fmt.Printf("  evidence: %s\n", truncate(p.Evidence, 120))
+			}
+		}
+		fmt.Println("\nConfirm with: odek memory extended confirm <id>")
+		return nil
+
+	case "confirm":
+		if len(subArgs) == 0 {
+			return fmt.Errorf("usage: odek memory extended confirm <pending_id>")
+		}
+		id := subArgs[0]
+		if err := em.ConfirmPendingReview(id); err != nil {
+			return err
+		}
+		fmt.Printf("odek: confirmed pending review %q\n", id)
+		return nil
+
+	case "reject":
+		if len(subArgs) == 0 {
+			return fmt.Errorf("usage: odek memory extended reject <pending_id>")
+		}
+		id := subArgs[0]
+		if err := em.RejectPendingReview(id); err != nil {
+			return err
+		}
+		fmt.Printf("odek: rejected pending review %q\n", id)
+		return nil
+
 	default:
-		return fmt.Errorf("unknown extended memory subcommand %q (expected: forget, promote, pin, quarantine, compact)", sub)
+		return fmt.Errorf("unknown extended memory subcommand %q (expected: forget, promote, pin, quarantine, compact, pending, confirm, reject)", sub)
 	}
 }