Skip to content

Commit 0cdc636

Browse files
author
molty3000
committed
fix: clean up session temp dirs in serve tests (TempDir cleanup failure in CI)
1 parent 56a478c commit 0cdc636

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

cmd/odek/serve_test.go

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -752,13 +752,17 @@ func setTestEnv(t *testing.T, llmBaseURL string) func() {
752752
origOAI := os.Getenv("OPENAI_API_KEY")
753753
origKBS := os.Getenv("ODEK_BASE_URL")
754754
origHome := os.Getenv("HOME")
755+
homeDir := t.TempDir()
755756

756757
os.Setenv("DEEPSEEK_API_KEY", "sk-mock")
757758
os.Unsetenv("OPENAI_API_KEY")
758759
os.Setenv("ODEK_BASE_URL", llmBaseURL)
759-
os.Setenv("HOME", t.TempDir())
760+
os.Setenv("HOME", homeDir)
760761

761762
return func() {
763+
// Clean up session files before Go removes the temp dir
764+
sessionDir := filepath.Join(homeDir, ".odek", "sessions")
765+
os.RemoveAll(sessionDir)
762766
os.Setenv("DEEPSEEK_API_KEY", origDS)
763767
os.Setenv("OPENAI_API_KEY", origOAI)
764768
os.Setenv("ODEK_BASE_URL", origKBS)
@@ -770,8 +774,14 @@ func setTestEnv(t *testing.T, llmBaseURL string) func() {
770774
func newTestSessionStore(t *testing.T) *session.Store {
771775
t.Helper()
772776
origHome := os.Getenv("HOME")
773-
os.Setenv("HOME", t.TempDir())
774-
t.Cleanup(func() { os.Setenv("HOME", origHome) })
777+
homeDir := t.TempDir()
778+
os.Setenv("HOME", homeDir)
779+
t.Cleanup(func() {
780+
// Clean up session files before Go removes the temp dir
781+
sessionDir := filepath.Join(homeDir, ".odek", "sessions")
782+
os.RemoveAll(sessionDir)
783+
os.Setenv("HOME", origHome)
784+
})
775785
store, err := session.NewStore()
776786
if err != nil {
777787
t.Fatalf("session.NewStore: %v", err)

0 commit comments

Comments
 (0)