v0.56.2 — Terminal UX compression, trimToSurvival fix, and cross-platform test fixes

Terminal rendering (vertical space compression):
- render.go: Start() no-op, remove blank lines from Iteration/FinalAnswer/Summary
- loop.go: remove duplicate pre-LLM iteration header call
- repl_editor.go: fix raw-mode cursor discipline (\r\n instead of bare \n)

trimToSurvival ordering bug (400 Bad Request fix):
- loop.go: fix group reversal that placed tool messages before assistant(tool_calls)
  by using [][]llm.Message sub-slices instead of flattening+reversing individual messages

Cross-platform test fixes:
- classifier.go: macOS /var/folders temp dirs classified as LocalWrite not SystemWrite
  (os.TempDir may include trailing slash on macOS; use filepath.Clean before prefix check)
- main_test.go: dockerAvailable() now verifies daemon reachability (docker info)
- restart_e2e_test.go: use t.TempDir() fixtures instead of hardcoded /root/.odek/skills

Author: jkyberneees

cmd/odek/main_test.go

@@ -755,8 +755,14 @@ func TestRun_WithProjectConfig(t *testing.T) {
 
 // dockerAvailable returns true if the docker CLI is available.
 func dockerAvailable() bool {
-	_, err := exec.LookPath("docker")
-	return err == nil
+	if _, err := exec.LookPath("docker"); err != nil {
+		return false
+	}
+	// Verify the daemon is actually reachable (not just the CLI installed).
+	cmd := exec.Command("docker", "info")
+	cmd.Stdout = nil
+	cmd.Stderr = nil
+	return cmd.Run() == nil
 }
 
 // ── Init Config Tests ─────────────────────────────────────────────────

cmd/odek/repl_editor.go

@@ -84,7 +84,7 @@ func (e *replEditor) ReadLine() (string, error) {
 				}
 				// Disable bracketed paste
 				fmt.Fprint(os.Stderr, "\x1b[?2004l")
-				fmt.Fprintln(os.Stderr)
+				fmt.Fprint(os.Stderr, "\r\n")
 				return result, nil
 			}
 		}

internal/danger/classifier.go

@@ -68,6 +68,16 @@ func ClassifyPath(path string) RiskClass {
 			return Destructive
 		}
 	}
+
+	// Temp directory paths are always local, not system. This handles
+	// macOS where temp dirs live under /var/folders/, preventing false
+	// SystemWrite classification (matching Linux /tmp behavior).
+	// os.TempDir may include a trailing separator on some platforms;
+	// Clean normalises it before the prefix check.
+	if tmpDir := filepath.Clean(os.TempDir()); abs == tmpDir || strings.HasPrefix(abs, tmpDir+string(filepath.Separator)) {
+		return LocalWrite
+	}
+
 	for _, prefix := range []string{"/etc", "/root", "/var", "/run", "/lib", "/usr"} {
 		if strings.HasPrefix(abs, prefix) {
 			return SystemWrite

internal/loop/loop.go

@@ -422,41 +422,55 @@ func trimToSurvival(msgs []llm.Message) []llm.Message {
 	}
 
 	// Collect the last 2 complete assistant→tool groups before the user msg.
-	var groups []llm.Message
+	// Each group is a sub-slice in correct internal order: [system*, assistant, tool*].
+	var groups [][]llm.Message
 	seen := 0
 	for i := lastUserIdx - 1; i > start && seen < 2; i-- {
 		if msgs[i].Role == "assistant" && len(msgs[i].ToolCalls) > 0 {
-			// This assistant message has tool calls — collect it and
-			// its following tool results.
-			groupEnd := i + 1
-			for groupEnd < len(msgs) && msgs[groupEnd].Role == "tool" {
-				groupEnd++
-			}
-			groups = append(groups, msgs[i:groupEnd]...)
-			// Also include any preceding system messages (corrections, warnings).
+			var group []llm.Message
+
+			// Preceding system messages (corrections, warnings)
 			preStart := i - 1
 			for preStart > start && msgs[preStart].Role == "system" {
 				preStart--
 			}
 			for k := preStart + 1; k < i; k++ {
-				groups = append(groups, msgs[k])
+				group = append(group, msgs[k])
+			}
+
+			// Assistant message with tool calls
+			group = append(group, msgs[i])
+
+			// Following tool results
+			for j := i + 1; j < len(msgs) && msgs[j].Role == "tool"; j++ {
+				group = append(group, msgs[j])
 			}
+
+			groups = append(groups, group)
+			i = preStart + 1 // skip past the group we just consumed
 			seen++
 		}
 	}
 
 	// Build survival set: system + task + recent groups + last user
-	survival := make([]llm.Message, 0, start+1+len(groups)+1)
+	// Calculate total messages across all groups for capacity hint
+	totalGroupMsgs := 0
+	for _, g := range groups {
+		totalGroupMsgs += len(g)
+	}
+	survival := make([]llm.Message, 0, start+1+totalGroupMsgs+1)
 	if start > 0 {
 		survival = append(survival, msgs[0]) // system message
 	}
 	// Add a context-warning system message
 	warning := "[Context trimmed to survive: the conversation history exceeded the model's context window. Earlier turns have been dropped. If you need information from earlier in the conversation, the agent may ask for a summary.]"
 	survival = append(survival, llm.Message{Role: "system", Content: warning})
 
-	// Add the recent groups (in chronological order, not reversed)
+	// Add the recent groups in chronological order (groups were collected
+	// from newest to oldest, so reverse them while preserving each group's
+	// internal order: system* → assistant(tool_calls) → tool*).
 	for i := len(groups) - 1; i >= 0; i-- {
-		survival = append(survival, groups[i])
+		survival = append(survival, groups[i]...)
 	}
 
 	// Add the last user message
@@ -515,11 +529,6 @@ func (e *Engine) runLoop(ctx context.Context, messages []llm.Message) (string, [
 		default:
 		}
 
-		// Render iteration header (1-indexed for humans)
-		if e.renderer != nil && e.interactionMode != "off" {
-			e.renderer.Iteration(i+1, e.maxIter, 0, 0, 0, 0)
-		}
-
 		// Trim context to stay within model's context window
 		messages = e.trimContext(messages, tools)
 

internal/render/render.go

@@ -123,20 +123,9 @@ func (r *Renderer) disable() bool {
 
 // ── Rendering methods ─────────────────────────────────────────────────
 
-// Start prints the session header with task preview.
-func (r *Renderer) Start(task string) {
-	if r.disable() {
-		return
-	}
-	preview := r.truncate(strings.ReplaceAll(task, "\n", " "), 80)
-	prefix := "⚡ odek"
-	if r.model != "" {
-		prefix += " · " + r.model
-	}
-	fmt.Fprintln(r.w, r.style(blue, prefix))
-	fmt.Fprintln(r.w, r.style(gray, "   "+preview))
-	fmt.Fprintln(r.w)
-}
+// Start is a no-op — session context is now shown via iteration headers
+// and session banners (REPL). Kept for API compatibility.
+func (r *Renderer) Start(task string) {}
 
 // Iteration prints the cycle header with optional turn statistics and
 // turn number. When turn > 0, shows "Turn N" in the header.
@@ -164,7 +153,6 @@ func (r *Renderer) Iteration(n, maxN int, latency time.Duration, inTokens, outTo
 	// Double-line rule framing
 	rule := strings.Repeat("═", 3)
 	line := fmt.Sprintf("%s %s %s%s", rule, prefix, rule, stats)
-	fmt.Fprintln(r.w)
 	fmt.Fprintln(r.w, r.style(blue, line))
 }
 
@@ -402,9 +390,7 @@ func (r *Renderer) FinalAnswer(text string) {
 	if r.disable() || text == "" {
 		return
 	}
-	fmt.Fprintln(r.w)
 	fmt.Fprintln(r.w, r.style(green, "✅ "+text))
-	fmt.Fprintln(r.w)
 }
 
 // Summary prints a run summary line with total token and cache statistics.
@@ -432,7 +418,6 @@ func (r *Renderer) Summary(inTokens, outTokens, cacheCreate, cacheRead, cached i
 		parts = append(parts, fmt.Sprintf("%d cached", cached))
 	}
 	fmt.Fprintln(r.w, r.style(gray, "── "+strings.Join(parts, " · ")))
-	fmt.Fprintln(r.w)
 }
 
 // Error prints a non-fatal loop error with a cross emoji.

internal/render/render_test.go

@@ -15,14 +15,8 @@ func TestRenderer_Start(t *testing.T) {
 	r.Start("list all files in this directory")
 
 	out := buf.String()
-	if !strings.Contains(out, "odek") {
-		t.Errorf("Start() missing odek brand: %q", out)
-	}
-	if !strings.Contains(out, "deepseek-chat") {
-		t.Errorf("Start() missing model name: %q", out)
-	}
-	if !strings.Contains(out, "list all files") {
-		t.Errorf("Start() missing task preview: %q", out)
+	if out != "" {
+		t.Errorf("Start() should be a no-op, got output: %q", out)
 	}
 }
 
@@ -34,9 +28,8 @@ func TestRenderer_Start_LongTask(t *testing.T) {
 	r.Start(longTask)
 
 	out := buf.String()
-	// Task preview should be truncated to ~80 chars
-	if strings.Count(out, "explain") > 6 {
-		t.Errorf("Start() should truncate long task: %q", out)
+	if out != "" {
+		t.Errorf("Start() should be a no-op even for long tasks, got output: %q", out)
 	}
 }
 

internal/skills/restart_e2e_test.go

@@ -1,19 +1,46 @@
 package skills
 
 import (
+	"os"
+	"path/filepath"
 	"strings"
 	"testing"
 )
 
+// setupRestartSkill creates a temp skills directory containing the
+// restart-odek-telegram skill and returns a SkillManager pointed at it.
+func setupRestartSkill(t *testing.T) *SkillManager {
+	t.Helper()
+
+	dir := t.TempDir()
+	skillDir := filepath.Join(dir, "restart-odek-telegram")
+	if err := os.MkdirAll(skillDir, 0755); err != nil {
+		t.Fatalf("failed to create skill dir: %v", err)
+	}
+
+	content := `---
+name: restart-odek-telegram
+description: Restart the odek Telegram bot
+odek:
+  trigger:
+    topic: odek, telegram, bot, restart, deploy, rebuild
+    action: restart, redeploy, rebuild, bounce
+  auto_load: false
+---
+Run build-and-restart-telegram.sh --restart-only with nohup. Do NOT use go build directly.
+`
+	if err := os.WriteFile(filepath.Join(skillDir, "SKILL.md"), []byte(content), 0644); err != nil {
+		t.Fatalf("failed to write SKILL.md: %v", err)
+	}
+
+	return NewSkillManager("", dir)
+}
+
 // TestRestartSkill_Triggers_ScoredMatcher verifies the scored matcher
 // correctly triggers the restart-odek-telegram skill for common user
 // inputs like "rebuild and restart", "restart the bot", etc.
 func TestRestartSkill_Triggers_ScoredMatcher(t *testing.T) {
-	if testing.Short() {
-		t.Skip("skipping E2E test in short mode (requires installed skills)")
-	}
-	sm := NewSkillManager("", "/root/.odek/skills")
-	sm.Reload()
+	sm := setupRestartSkill(t)
 
 	// The restart skill should be in the Lazy pool (auto_load: false)
 	found := false
@@ -63,11 +90,7 @@ func TestRestartSkill_Triggers_ScoredMatcher(t *testing.T) {
 // actually directs the agent to use the build-and-restart script,
 // not manual build or kill commands.
 func TestRestartSkill_BodyContainsScript(t *testing.T) {
-	if testing.Short() {
-		t.Skip("skipping E2E test in short mode (requires installed skills)")
-	}
-	sm := NewSkillManager("", "/root/.odek/skills")
-	sm.Reload()
+	sm := setupRestartSkill(t)
 
 	matched := sm.ScoredMatcher.MatchSkills("rebuild and restart", 1)
 	if len(matched) == 0 {