fix(extended-memory): transactional eviction and gofmt cleanup

- Move eviction after the ok check so atoms are only removed when the cap can be satisfied.
- gofmt changed files in internal/memory/extended.

Author: jkyberneees

internal/memory/extended/config.go

@@ -16,21 +16,21 @@ import (
 
 // Config controls the Extended Memory subsystem.
 type Config struct {
-	Enabled                 *bool            `json:"enabled,omitempty"`
-	MaxSizeMB               int              `json:"max_size_mb,omitempty"`
-	SemanticSearchTopK      int              `json:"semantic_search_top_k,omitempty"`
-	SemanticSearchOverfetch int              `json:"semantic_search_overfetch,omitempty"`
-	SemanticSearchMinScore  float32          `json:"semantic_search_min_score,omitempty"`
-	SemanticSearchRerank    *bool            `json:"semantic_search_rerank,omitempty"`
-	AtomMaxChars            int              `json:"atom_max_chars,omitempty"`
-	MemoryBudgetChars       int              `json:"memory_budget_chars,omitempty"`
-	DecayHalfLifeDays       int              `json:"decay_half_life_days,omitempty"`
-	QuarantineTTLDays       int              `json:"quarantine_ttl_days,omitempty"`
-	EvictionPolicy          string           `json:"eviction_policy,omitempty"`
-	PredictiveIntents       int              `json:"predictive_intents,omitempty"`
-	AutoExtractPerTurn      *bool            `json:"auto_extract_per_turn,omitempty"`
-	InferUserState          *bool            `json:"infer_user_state,omitempty"`
-	LLM                     *LLMConfig       `json:"llm,omitempty"`
+	Enabled                 *bool             `json:"enabled,omitempty"`
+	MaxSizeMB               int               `json:"max_size_mb,omitempty"`
+	SemanticSearchTopK      int               `json:"semantic_search_top_k,omitempty"`
+	SemanticSearchOverfetch int               `json:"semantic_search_overfetch,omitempty"`
+	SemanticSearchMinScore  float32           `json:"semantic_search_min_score,omitempty"`
+	SemanticSearchRerank    *bool             `json:"semantic_search_rerank,omitempty"`
+	AtomMaxChars            int               `json:"atom_max_chars,omitempty"`
+	MemoryBudgetChars       int               `json:"memory_budget_chars,omitempty"`
+	DecayHalfLifeDays       int               `json:"decay_half_life_days,omitempty"`
+	QuarantineTTLDays       int               `json:"quarantine_ttl_days,omitempty"`
+	EvictionPolicy          string            `json:"eviction_policy,omitempty"`
+	PredictiveIntents       int               `json:"predictive_intents,omitempty"`
+	AutoExtractPerTurn      *bool             `json:"auto_extract_per_turn,omitempty"`
+	InferUserState          *bool             `json:"infer_user_state,omitempty"`
+	LLM                     *LLMConfig        `json:"llm,omitempty"`
 	Embedding               *embedding.Config `json:"embedding,omitempty"`
 }
 

internal/memory/extended/extended_memory.go

@@ -317,6 +317,9 @@ func (em *ExtendedMemory) enforceCap(ctx context.Context, newBytes int64) error
 	need := total - maxBytes + 4096 // headroom
 	before := len(atoms)
 	ids, _, ok := em.evictor.SelectForEviction(sized, need)
+	if !ok {
+		return fmt.Errorf("extended memory: cannot free %s; all atoms are pinned or no evictable atoms exist", sizeLabel(need))
+	}
 	for _, id := range ids {
 		_ = em.store.Remove(id)
 		em.index.markDirty()
@@ -329,9 +332,6 @@ func (em *ExtendedMemory) enforceCap(ctx context.Context, newBytes int64) error
 		}
 	}
 
-	if !ok {
-		return fmt.Errorf("extended memory: cannot free %s; all atoms are pinned or no evictable atoms exist", sizeLabel(need))
-	}
 	return nil
 }
 

internal/memory/extended/extended_memory_test.go

@@ -193,7 +193,7 @@ func TestExtendedMemoryAddAndSearch(t *testing.T) {
 	}
 
 	atom := MemoryAtom{
-		Text:     "User prefers Go for backend services",
+		Text:        "User prefers Go for backend services",
 		SourceClass: SourceUserSaid,
 		Type:        TypePreference,
 	}
@@ -838,4 +838,3 @@ func TestAddAtomsBatchFailurePath(t *testing.T) {
 		t.Errorf("expected 2 live atoms, got %d", len(live))
 	}
 }
-

internal/memory/extended/quarantine_test.go

@@ -112,4 +112,3 @@ func TestQuarantineTTLDisabled(t *testing.T) {
 		t.Errorf("expected 0 evicted with TTL disabled, got %d", removed)
 	}
 }
-

internal/memory/extended/recall.go

@@ -12,10 +12,10 @@ import (
 
 // Recall performs semantic search over the atom store.
 type Recall struct {
-	store  *AtomStore
-	index  *atomVectorIndex
-	llm    LLMClient
-	cfg    Config
+	store *AtomStore
+	index *atomVectorIndex
+	llm   LLMClient
+	cfg   Config
 }
 
 // NewRecall creates a Recall instance.