feat(memory): inherit unset memory.extended.llm fields from main LLM#101
Merged
Conversation
memory.extended.llm was all-or-nothing: without base_url AND model it
fell back to the main client entirely, so operators could not override a
single knob (e.g. thinking) without duplicating the parent connection
settings.
ResolveLLM now inherits empty fields (base_url, api_key, model,
thinking, max_tokens, temperature) from the main *llm.Client before
building the dedicated client, enabling partial overrides such as:
"llm": {"thinking": "disabled"} // same model, no reasoning for memory
"llm": {"model": "qwen2.5:7b"} // cheaper model, same backend
Fallback semantics are preserved: if base_url/model are still empty
after inheritance, it warns and reuses the main client as before.
Also patch the docker configs (godmode + restricted) to disable thinking
for extended memory calls via the new partial override, and document the
inheritance behavior in CONFIG.md and EXTENDED_MEMORY.md.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
odek | 7b77c99 | Commit Preview URL Branch Preview URL |
Jul 25 2026, 02:40 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
memory.extended.llmwas all-or-nothing: without bothbase_urlandmodel,ResolveLLMfell back to the main client entirely. Operators could not override a single knob — e.g. disabling thinking for memory calls — without duplicating the parent'sbase_url/api_key/model.Change
ResolveLLMnow inherits empty fields (base_url,api_key,model,thinking,max_tokens,temperature) from the main*llm.Clientbefore building the dedicated client. Partial overrides now work:Fallback semantics are preserved: if
base_url/modelare still empty after inheritance (e.g. the main client is not an*llm.Client), it warns and reuses the main client as before.timeout_secondsis not inherited (the main client's timeout is unexported) and still defaults to 30s.Docker setup
Both docker configs (
config.godmode.json,config.restricted.json) now setmemory.extended.llm.thinking: "disabled"via the new partial override, so memory extraction/rerank/predictor calls skip reasoning tokens while reusing the parent backend.Testing
TestResolveLLMInheritsMainSettings— thinking-only override inherits base_url/api_key/model/max_tokens/temperatureTestResolveLLMPartialOverrideKeepsInheritedRest— model-only override keeps the parent backendinternal/memory/...suite green with-raceDocs updated:
docs/CONFIG.md(memory.extended.llmrow) anddocs/EXTENDED_MEMORY.md(Dedicated Memory LLM section).