fix: redact Groq, xAI, HuggingFace keys and underscores in sk- keys (M-11) - #68
Merged
Merged
Conversation
…M-11) Adds missing provider secret patterns and closes the Anthropic-key escape where an underscore appeared in the first ~19 body chars. Changes: - internal/redact/redact.go: added gsk_, xai-, hf_ patterns and included '_' in the sk- character class. - Added TestRedactSecrets_ProviderKeys and expanded coverage cases. - Updated TestReport_RedactMissesRealSecretFormats. - Updated docs/SECURITY.md and AGENTS.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes secret-redaction gaps for Groq (gsk_), xAI (xai-), HuggingFace (hf_), and Anthropic keys with underscores in the sk- body (M-11).\n\nChanges:\n- internal/redact/redact.go: added provider-specific patterns and included '_' in the sk- character class.\n- Added/expanded tests in internal/redact/redact_test.go and cmd/odek/security_report_validation_test.go.\n- Updated docs/SECURITY.md and AGENTS.md.