fix: close rm wipe-target and flag bypasses (M-12) - #69
Merged
Conversation
The danger classifier treated rm -rf ./ as local_write (equivalent to rm -rf .) and missed -rf default-value flag substitutions. Changes: - internal/danger/classifier.go: isWipeTarget now normalises a leading ./ so ./ and ./.. match . and ..; rmRecursiveOrForce treats <flags> substitutions as fail-closed. - Added regression tests for rm -rf ./, rm -rf ./.., and rm -rf /. - Updated docs/SECURITY.md and AGENTS.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes two rm-related danger-classifier bypasses (M-12):\n\n- rm -rf ./ and rm -rf ./.. are now caught the same as . and .. after normalising a leading ./.\n- default-value parameter expansions that expand to rm flags are treated as fail-closed.\n\nChanges:\n- internal/danger/classifier.go: updated rmRecursiveOrForce and isWipeTarget.\n- Added regression tests.\n- Updated docs/SECURITY.md and AGENTS.md.