L10: harden REPL history file permissions to 0600 - #82
Merged
Conversation
- cmd/odek/repl_editor.go: chmod existing repl_history to 0600 and open new files with O_WRONLY|O_CREATE|O_TRUNC and mode 0600, replacing the previous os.Create default permissions. - cmd/odek/repl_editor_test.go: regression tests for restricted creation and hardening of existing world-readable files. - docs/SECURITY.md + AGENTS.md: document L10 mitigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes L10.
replHistory.persist()now chmods any existing~/.odek/repl_historyto0600and opens new files withO_WRONLY|O_CREATE|O_TRUNCand mode0600./cc @BackendStack21/odek