Final button bindings#81
Conversation
Teleop Controls Changed
I know it looks bad, but i just renamed the symbols i promise, also things look consistent now. Same Usage style, cone in is cube out, cube in is cone out.
This reverts commit 584a71f.
…014/BadRobot2023 into final-button-bindings
Final Button Binding Settings
Obloberated Final Shuffleboard and Controls Fixed
…014/BadRobot2023 into final-button-bindings
| m_drivesubsystem = drivesubsystem; | ||
| m_ledSubsystem = lightSubsystem; | ||
| // Use addRequirements() here to declare subsystem dependencies. | ||
| addRequirements(subsystem, drivesubsystem); |
There was a problem hiding this comment.
Do we need lightSubsystem here too?
| addRequirements(subsystem, drivesubsystem); | |
| addRequirements(subsystem, drivesubsystem, lightSubsystem); |
There was a problem hiding this comment.
to clarify what I mean: since we use it here, shouldn't we add it to the requirements call.
|
so it doesn't get lost... let's make sure we take into account the feedback on #82 |
| @@ -20,7 +20,9 @@ public class ArmSubsystem extends SubsystemBase { | |||
|
|
|||
| public final CANSparkMax m_winch = new CANSparkMax(ArmConstants.kWinchPort, CANSparkMaxLowLevel.MotorType.kBrushless); // Assume Brushless, unknown currently | |||
There was a problem hiding this comment.
| public final CANSparkMax m_winch = new CANSparkMax(ArmConstants.kWinchPort, CANSparkMaxLowLevel.MotorType.kBrushless); // Assume Brushless, unknown currently | |
| public final CANSparkMax m_winch = new CANSparkMax(ArmConstants.kWinchPort, CANSparkMaxLowLevel.MotorType.kBrushed); |
According to Philippe, this should be Brushed
kanno41
left a comment
kanno41
left a comment
There was a problem hiding this comment.
If using DriveDistance, make sure to implement it in the auton commands. Generally, we want to measure things in meters rather than inches in an engineering context, but it's fine for now
| // Returns true when the command should end. | ||
| @Override | ||
| public boolean isFinished() { | ||
| return m_drivesubsystem.getLeftEncoder() > m_inches / DriveConstants.kInchesPerTic; |
There was a problem hiding this comment.
I think we need to take into account whether it is driving backwards or forwards here. Perhaps use Math.abs?
There was an issue, now there's not.
BowlesCR
force-pushed
the
final-button-bindings
branch
from
7c65242 to
d95fc07
Compare
| System.out.println((m_position - 6 * armAdjustValue)); | ||
| m_armSubsystem.runToPosition(m_armSubsystem.m_extender, m_armSubsystem.m_extenderEncoder, (m_position - (6 * armAdjustValue)), m_speed); | ||
| System.out.println((m_position - 8 * armAdjustValue)); | ||
| m_armSubsystem.runToPosition(m_armSubsystem.m_extender, m_armSubsystem.m_extenderEncoder, (m_position - (8 * armAdjustValue)), m_speed); |
|
You have successfully added a new QDJVMC configuration |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| public boolean isGrabberFilled(){ | ||
| if(getGrabberState() == ArmConstants.kGrabberFilled){ |
Check warning
Code scanning / QDJVMC
String comparison using '==', instead of 'equals()'
8 participants
Obliberated button bindings