FIX: Undo caused crash when inserting newline at the end of text#32
FIX: Undo caused crash when inserting newline at the end of text#32Rasa0 wants to merge 27 commits intoBalazsJako:masterfrom Rasa0:master
Conversation
… reacting to clicks when pointing at the text. Now auto scrolling up and down when dragging cursor outside the text area.
… the text as dirty. Useful for being able to save to file.
… highlight Added the abillity to toggle breakpoints. Added a breakpoints changed callback.
Fixed missing check for keywords starting with 'e' Lexer now colors the code as it runns. Now lexing numbers aswell
Now putting the name in name tokens Now putting message in malformed number token
…aren't added as a token anymore
…e didn't initialize isVararg, causing all functions to be vararg
…ues. Shows the values when variables are hovered now. Now using a constant instead of magical value of -1 to indicate when program counter is disabled
BalazsJako
left a comment
BalazsJako
left a comment
There was a problem hiding this comment.
Is it really necessary to include imgui_internal.h? I would like to keep the source independent of ImGUI's internal structures.
|
Whoa... that's a big list of changes. Is it possible to break it down into smaller ones? I would like to merge most of them, but not all, at least not at once. Can we discuss it please? |
|
Whops. I thought i made the fix based on the origin, must have been tired when i made the request. My current version have been heavily modified to fit my purposes (Focus on Lua only). And now it have some tight coupling to my private project making it unfit for sharing. I could try to split out the general parts into a public fork, but that will require some work reorganizing the commits. The inclusion of imgui_internal.h was because I'm using ImRect. |
|
Ok, that would be great, I think it is enough to split it into a few separate commits, grouped by topic. Just let me know if you have done it. I keep avoiding using inclusion of imgui_internal.h because I do not want to have any extra dependencies on ImGUI's internals, which might change every now and then and might cause extra work necessary every time the code is compiled against the new version of ImGUI. |
Make Boost regex a private dependency
2 participants
Line 195 causes "vector subscript out of range" when undoing a newline on the last line.
Unsure if this is a proper fix or if it could be made better.