refactor: remove ConnectStatus enum and connect status fields from ReadyMetadata

Author: smoghe-bw

src/types.ts

@@ -21,15 +21,6 @@ export enum EndpointType {
   PHONE_NUMBER = "PHONE_NUMBER",
 }
 
-export enum ConnectStatus {
-  INITIATED = "INITIATED",
-  COMPLETED = "COMPLETED",
-  TIMED_OUT = "TIMED_OUT",
-  DENIED = "DENIED",
-  CANCELED = "CANCELED",
-  FAILED = "FAILED",
-}
-
 export type AudioLevelChangeHandler = { (audioLevel: AudioLevel): void };
 
 /**
@@ -59,15 +50,6 @@ export interface ReadyMetadata {
   deviceId: string;
   territory: string; // TODO enum
   region: string; // TODO enum
-  connectStatus?: ConnectStatus;
-  accountId?: string;
-  sessionId?: string;
-  from?: string;
-  fromType?: string;
-  fromTags?: string;
-  to?: string;
-  toType?: string;
-  toTags?: string;
 }
 
 export interface OutboundConnectionResult {

src/v1/signaling.test.ts

@@ -94,47 +94,19 @@ describe("Signaling connect method", () => {
     }
   });
 
-  test("should emit ready with connectStatus fields when gateway sends ready with connect status data", async () => {
+  test("should emit established when websocket receives established", async () => {
     const emitSpy = jest.spyOn(signaling, "emit");
 
     await signaling.connect({ endpointToken: "test-token" });
 
-    // Simulate a second ready event from the gateway that includes connect status fields
+    // Get the websocket instance and trigger established event
     const ws = (signaling as any).ws;
-    const readyCallback = ws.on.mock.calls.find((call: any) => call[0] === "ready")?.[1];
-
-    if (readyCallback) {
-      const readyWithConnectStatus = {
-        endpointId: "test-endpoint",
-        deviceId: "device-1",
-        territory: "US",
-        region: "us-east-1",
-        connectStatus: "COMPLETED",
-        accountId: "9900000",
-        sessionId: "session-1",
-        from: "ep-1",
-        fromType: "ENDPOINT",
-        fromTags: "tag1",
-        to: "ep-2",
-        toType: "ENDPOINT",
-        toTags: "tag2",
-      };
-      readyCallback(readyWithConnectStatus);
-      expect(emitSpy).toHaveBeenCalledWith(
-        "ready",
-        expect.objectContaining({
-          endpointId: "test-endpoint",
-          connectStatus: "COMPLETED",
-          accountId: "9900000",
-          sessionId: "session-1",
-          from: "ep-1",
-          fromType: "ENDPOINT",
-          fromTags: "tag1",
-          to: "ep-2",
-          toType: "ENDPOINT",
-          toTags: "tag2",
-        }),
-      );
+    const establishedCallback = ws.on.mock.calls.find((call: any) => call[0] === "established")?.[1];
+
+    if (establishedCallback) {
+      const testEvent = { connectionId: "test-connection" };
+      establishedCallback(testEvent);
+      expect(emitSpy).toHaveBeenCalledWith("established", testEvent);
     }
   });
 });

src/v1/types.ts

@@ -1,4 +1,4 @@
-import { MediaType, ConnectStatus } from "../types";
+import { MediaType } from "../types";
 
 export interface SetMediaPreferencesWebRtcResponse {
   endpointId: string;
@@ -69,13 +69,4 @@ export interface ReadyMetadata {
   deviceId: string;
   territory: string; // TODO enum
   region: string; // TODO enum
-  connectStatus?: ConnectStatus;
-  accountId?: string;
-  sessionId?: string;
-  from?: string;
-  fromType?: string;
-  fromTags?: string;
-  to?: string;
-  toType?: string;
-  toTags?: string;
 }