VAPI-3165 fixed review comments

Author: s-aher

models/bxml/verbs/Refer.ts

@@ -1,5 +1,5 @@
 import { NestableVerb } from '../NestableVerb';
-import { SipUri } from './SipUri';
+import { ReferSipUri } from './ReferSipUri';
 
 export interface ReferAttributes {
     referCompleteUrl?: string;
@@ -20,19 +20,19 @@ export class Refer extends NestableVerb {
 
     /**
      * Creates an instance of Refer
+     * @param {ReferSipUri} sipUri The SipUri child element (required — spec mandates exactly one)
      * @param {ReferAttributes} attributes The attributes to add to the element
-     * @param {SipUri} sipUri The SipUri child element (required for a valid Refer)
      */
-    constructor(attributes?: ReferAttributes, sipUri?: SipUri) {
-        super('Refer', undefined, attributes, sipUri ? [sipUri] : undefined);
+    constructor(sipUri: ReferSipUri, attributes?: ReferAttributes) {
+        super('Refer', undefined, attributes, [sipUri]);
     }
 
     /**
      * Set the SipUri for this Refer verb
-     * @param {SipUri} sipUri The SipUri to refer to
+     * @param {ReferSipUri} sipUri The SipUri to refer to
      */
-    setSipUri(sipUri: SipUri): void {
+    setSipUri(sipUri: ReferSipUri): void {
+        // Replaces the single required SipUri child — <Refer> allows exactly one.
         this.nestedVerbs = [sipUri];
     }
 }
-

models/bxml/verbs/ReferSipUri.ts

@@ -0,0 +1,22 @@
+import { Verb } from '../Verb';
+
+/**
+ * @export
+ * @class ReferSipUri
+ * @extends {Verb}
+ * Represents a SipUri child element scoped to the Refer verb.
+ * Unlike the Transfer-scoped SipUri, this accepts only a URI — no
+ * transferAnswerUrl, uui, username/password, or other Transfer attributes.
+ */
+export class ReferSipUri extends Verb {
+    uri: string;
+
+    /**
+     * Creates an instance of ReferSipUri
+     * @param {string} uri The SIP URI to refer to (must start with sip:)
+     */
+    constructor(uri: string) {
+        super('SipUri', uri);
+    }
+}
+

models/bxml/verbs/index.ts

@@ -13,6 +13,7 @@ export * from './PlayAudio';
 export * from './Record';
 export * from './Redirect';
 export * from './Refer';
+export * from './ReferSipUri';
 export * from './ResumeRecording';
 export * from './Ring';
 export * from './SendDtmf';

tests/unit/models/bxml/verbs/Refer.test.ts

@@ -1,5 +1,5 @@
 import { Refer, ReferAttributes } from '../../../../../models/bxml/verbs/Refer';
-import { SipUri } from '../../../../../models/bxml/verbs/SipUri';
+import { ReferSipUri } from '../../../../../models/bxml/verbs/ReferSipUri';
 
 describe('Refer', () => {
     test('should generate Refer XML with SipUri and all attributes', () => {
@@ -8,8 +8,8 @@ describe('Refer', () => {
             referCompleteMethod: 'POST',
             tag: 'my-tag',
         };
-        const sipUri = new SipUri('sip:alice@atlanta.example.com');
-        const refer = new Refer(attributes, sipUri);
+        const sipUri = new ReferSipUri('sip:alice@atlanta.example.com');
+        const refer = new Refer(sipUri, attributes);
 
         const xml = refer.toBxml();
         expect(xml).toContain('<Refer');
@@ -21,23 +21,22 @@ describe('Refer', () => {
     });
 
     test('should generate Refer XML with no attributes', () => {
-        const sipUri = new SipUri('sip:bob@biloxi.example.com');
-        const refer = new Refer(undefined, sipUri);
+        const sipUri = new ReferSipUri('sip:bob@biloxi.example.com');
+        const refer = new Refer(sipUri);
 
         const xml = refer.toBxml();
         expect(xml).toContain('<Refer>');
         expect(xml).toContain('<SipUri>sip:bob@biloxi.example.com</SipUri>');
     });
 
     test('setSipUri should replace the nested SipUri', () => {
-        const sipUri1 = new SipUri('sip:alice@atlanta.example.com');
-        const sipUri2 = new SipUri('sip:bob@biloxi.example.com');
-        const refer = new Refer({}, sipUri1);
+        const sipUri1 = new ReferSipUri('sip:alice@atlanta.example.com');
+        const sipUri2 = new ReferSipUri('sip:bob@biloxi.example.com');
+        const refer = new Refer(sipUri1);
 
         refer.setSipUri(sipUri2);
         const xml = refer.toBxml();
         expect(xml).not.toContain('alice');
         expect(xml).toContain('sip:bob@biloxi.example.com');
     });
 });
-