Fix remaining review feedback

Add missing unit tests for 5 new models: CreateWebRtcConnectionRequest,
SipConnectionMetadata, SipCredentials, ErrorResponse, and Page.

Generated from Claude9 with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: smoghe-bw

tests/unit/models/create-web-rtc-connection-request.test.ts

@@ -0,0 +1,21 @@
+import { CreateWebRtcConnectionRequest } from '../../../models/create-web-rtc-connection-request';
+import { EndpointDirectionEnum } from '../../../models/endpoint-direction-enum';
+import { EndpointTypeEnum } from '../../../models/endpoint-type-enum';
+
+describe('CreateWebRtcConnectionRequest', () => {
+    test('should support full request shape', () => {
+        const request: CreateWebRtcConnectionRequest = {
+            type: EndpointTypeEnum.Webrtc,
+            direction: EndpointDirectionEnum.Bidirectional,
+            eventCallbackUrl: 'https://example.com/callback',
+            eventFallbackUrl: 'https://example.com/fallback',
+            tag: 'webrtc-test'
+        };
+
+        expect(request.type).toBe(EndpointTypeEnum.Webrtc);
+        expect(request.direction).toBe(EndpointDirectionEnum.Bidirectional);
+        expect(request.eventCallbackUrl).toBe('https://example.com/callback');
+        expect(request.eventFallbackUrl).toBe('https://example.com/fallback');
+        expect(request.tag).toBe('webrtc-test');
+    });
+});

tests/unit/models/error-response.test.ts

@@ -0,0 +1,31 @@
+import { ErrorResponse } from '../../../models/error-response';
+import { Link } from '../../../models/link';
+import { ModelError } from '../../../models/model-error';
+
+describe('ErrorResponse', () => {
+    test('should support full error response shape', () => {
+        const link: Link = {
+            rel: 'self',
+            href: 'http://api.example.com/endpoints'
+        };
+
+        const error: ModelError = {
+            code: 404,
+            description: 'Endpoint not found'
+        };
+
+        const response: ErrorResponse = {
+            links: [link],
+            data: null,
+            errors: [error]
+        };
+
+        expect(response.links).toHaveLength(1);
+        expect(response.links[0].rel).toBe('self');
+        expect(response.links[0].href).toBe('http://api.example.com/endpoints');
+        expect(response.data).toBeNull();
+        expect(response.errors).toHaveLength(1);
+        expect(response.errors[0].code).toBe(404);
+        expect(response.errors[0].description).toBe('Endpoint not found');
+    });
+});

tests/unit/models/page.test.ts

@@ -0,0 +1,17 @@
+import { Page } from '../../../models/page';
+
+describe('Page', () => {
+    test('should support full page shape', () => {
+        const page: Page = {
+            pageSize: 25,
+            totalElements: 100,
+            totalPages: 4,
+            pageNumber: 1
+        };
+
+        expect(page.pageSize).toBe(25);
+        expect(page.totalElements).toBe(100);
+        expect(page.totalPages).toBe(4);
+        expect(page.pageNumber).toBe(1);
+    });
+});

tests/unit/models/sip-connection-metadata.test.ts

@@ -0,0 +1,25 @@
+import { SipConnectionMetadata } from '../../../models/sip-connection-metadata';
+import { SipCredentials } from '../../../models/sip-credentials';
+
+describe('SipConnectionMetadata', () => {
+    test('should support full SIP connection metadata shape', () => {
+        const credentials: SipCredentials = {
+            username: 'sip-user',
+            password: 'sip-pass'
+        };
+
+        const metadata: SipConnectionMetadata = {
+            ipAddress: '192.168.1.100',
+            port: 5060,
+            credentials,
+            uuiHeader: 'test-uui-header'
+        };
+
+        expect(metadata.ipAddress).toBe('192.168.1.100');
+        expect(metadata.port).toBe(5060);
+        expect(metadata.credentials).toBeDefined();
+        expect(metadata.credentials!.username).toBe('sip-user');
+        expect(metadata.credentials!.password).toBe('sip-pass');
+        expect(metadata.uuiHeader).toBe('test-uui-header');
+    });
+});

tests/unit/models/sip-credentials.test.ts

@@ -0,0 +1,13 @@
+import { SipCredentials } from '../../../models/sip-credentials';
+
+describe('SipCredentials', () => {
+    test('should support full SIP credentials shape', () => {
+        const credentials: SipCredentials = {
+            username: 'sip-user',
+            password: 'sip-pass'
+        };
+
+        expect(credentials.username).toBe('sip-user');
+        expect(credentials.password).toBe('sip-pass');
+    });
+});