feat(csp): add support for Content-Security-Policy-Report-Only header#672
feat(csp): add support for Content-Security-Policy-Report-Only header#672Gonzo17 wants to merge 2 commits intoBaroshem:mainfrom
Conversation
|
@Gonzo17 is attempting to deploy a commit to the Baroshem's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey Buddy, Thanks for creating this issue. It is clear that a lot of work was done (and a good work)! But I am not convinced to this approach with passing report-only in the headers for CSP. The report only is a completely different header and passing it inside CSPay cause unwanted confusion (as currently everything passed to security.headers.contentSecurityPolicy is converted to native browser headers). This feature will break this stability. I think the initial solution with passing it as a separate config option would be better as it does not interfere with the existing native headers :) Also, I highly recommend you to check out this PR -> nuxt/nuxt#32242 Feel free to contribute that change there as well :) |
Hey! Thank you for your feedback. :) I'm totally fine with adjusting, I understand your points!
I'll update the PR soon. :)
Oh that's interesting :) Yes, I'd like to do that after finishing this PR! |
|
I've pushed the changes, please have a look :) |
Baroshem
left a comment
There was a problem hiding this comment.
Great work! I approve it. Let's wait for few more bugs/features so that I could release a next minor version :)
Types of changes
Description
Support for Content-Security-Policy-Report-Only header, either globally or per route.
Resolves #605
Checklist: