Skip to content

Commit d131613

Browse files
committed
Remove duplicated template between job and request
1 parent 27216fa commit d131613

2 files changed

Lines changed: 5 additions & 26 deletions

File tree

lib/rorvswild/local/javascript/local.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,17 +125,17 @@ RorVsWild.Local.formatDateTime = function(date) {
125125
return [date.getDate(), months[date.getMonth()], hours + ":" + minutes].join(" ")
126126
}
127127

128-
RorVsWild.Local.prototype.goToExecutionDetail = function(execution, view) {
128+
RorVsWild.Local.prototype.goToExecutionDetail = function(execution) {
129129
this.currentExecution = execution
130130
execution.resetSectionFilters()
131131
execution.loadSections()
132-
this.render(view)
132+
this.render("Execution")
133133
execution.renderSections()
134134
}
135135

136136
RorVsWild.Local.prototype.goToRequestDetail = function(event) {
137137
var uuid = event.currentTarget.dataset.uuid
138-
this.goToExecutionDetail(this.requests.find(function(req) { return req.uuid == uuid }), "RequestDetail")
138+
this.goToExecutionDetail(this.requests.find(function(req) { return req.uuid == uuid }))
139139
}
140140

141141
RorVsWild.Local.prototype.goToRequestIndex = function(event) {
@@ -150,7 +150,7 @@ RorVsWild.Local.prototype.goToJobIndex = function(event) {
150150

151151
RorVsWild.Local.prototype.goToJobDetail = function(event) {
152152
var uuid = event.currentTarget.dataset.uuid
153-
this.goToExecutionDetail(this.jobs.find(function(job) { return job.uuid == uuid }), "JobDetail")
153+
this.goToExecutionDetail(this.jobs.find(function(job) { return job.uuid == uuid }))
154154
}
155155

156156
RorVsWild.Local.prototype.goToErrors = function(event) {

lib/rorvswild/local/local.html.erb

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -106,28 +106,7 @@
106106
</div>
107107
</script>
108108

109-
<script type="x-tmpl-mustache" data-partial="RorVsWild.Local.RequestDetail">
110-
{{#currentExecution}}
111-
<div class="rorvswild-local-panel__details">
112-
<div class="rorvswild-local-panel__details__header">
113-
<span class="rorvswild-local-panel__name">
114-
<h2 class="rorvswild-local-panel__title">{{name}}</h2>
115-
<span class="rorvswild-local-panel__path">
116-
{{path}}
117-
</span>
118-
</span>
119-
<span class="rorvswild-local-panel__runtime">{{runtime}}<small>ms</small></span>
120-
<span class="rorvswild-local-panel__started-at">{{queuedAt}}</span>
121-
</div>
122-
<div class="rorvswild-local-panel__details__sections">
123-
<div id="rorvswild-local-sections-header"></div>
124-
<div id="rorvswild-local-sections-list"></div>
125-
</div>
126-
</div>
127-
{{/currentExecution}}
128-
</script>
129-
130-
<script type="x-tmpl-mustache" data-partial="RorVsWild.Local.JobDetail">
109+
<script type="x-tmpl-mustache" data-partial="RorVsWild.Local.Execution">
131110
{{#currentExecution}}
132111
<div class="rorvswild-local-panel__details">
133112
<div class="rorvswild-local-panel__details__header">

0 commit comments

Comments
 (0)