Skip to content

Fix HTML content escaping #2648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristianGruen merged 1 commit into from
Apr 22, 2026
+6 −1
Merged

Fix HTML content escaping #2648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion basex-core/src/main/java/org/basex/io/serial/HTMLSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ protected void finishEmpty() throws IOException {
sep = false;
super.finishClose();
}
if(SCRIPTS.contains(lc(elem.local()))) script++;
}

@Override
Expand Down
6 changes: 6 additions & 0 deletions basex-core/src/test/java/org/basex/query/SerializerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,12 @@ public final class SerializerTest extends SandboxTest {
contains(option + "<html><style/><body><script>&amp;&amp;</script></body></html>", ">&&<");
}

/** HTML Serialization: restore escaping following empty script tags. */
@Test public void gh2645() {
final String option = METHOD.arg("html");
contains(option + "<html><script/><body>&amp;&amp;</body></html>", ">&amp;&amp;<");
}

/** HTML5 indentation. */
@Test public void indentHTML5() {
final String option = METHOD.arg("html") + INDENT.arg("on");
Expand Down
Loading