CGDMF-141: Extend Integrity Value calculation service#178
Merged
Conversation
wouterpot
force-pushed
the
CGDMF-140-file-integrity
branch
2 times, most recently
from
9a0596e to
094bcf5
Compare
wouterpot
force-pushed
the
CGDMF-141-remaining-integrity-algos
branch
from
7c17a5c to
aa7a4e1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the IntegrityCalculationService to support additional integrity algorithms from the Documenten API model (CRC-16/64, Fletcher variants, and HMAC), and refactors the hashing logic into shared helpers used by both byte-array and streaming entrypoints.
Changes:
- Added checksum/hash implementations and a shared
computeHash()dispatcher for moreIntegriteitAlgoritmevalues. - Refactored MessageDigest selection into a helper (
toJavaMessageDigestName()). - Updated
withIntegrity()to support the new algorithms, buffering the stream for algorithms without a built-in Java streaming filter.
wouterpot
force-pushed
the
CGDMF-140-file-integrity
branch
3 times, most recently
from
931b253 to
a89d6a5
Compare
wouterpot
force-pushed
the
CGDMF-141-remaining-integrity-algos
branch
3 times, most recently
from
d2fcf7c to
0c7a5f5
Compare
wouterpot
force-pushed
the
CGDMF-140-file-integrity
branch
from
024ea30 to
62e51cf
Compare
wouterpot
force-pushed
the
CGDMF-141-remaining-integrity-algos
branch
from
0c7a5f5 to
ddd9d91
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Make calculating HMAC fail. it's only possible to do with a secret, and we won't have that generally.
wouterpot
force-pushed
the
CGDMF-141-remaining-integrity-algos
branch
from
4d6e9de to
3c21385
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.