You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds the 'android.permission.POST_NOTIFICATIONS' permission to the Android manifest. This is required for apps targeting API 33 (Android 13) and above to use NotificationManagerCompat.notify without build failures related to missing permissions.
We prefer not to add permissions to the AndroidManifest.xml file of the plugin it self. As these permissions will be merged into the AndroidManifest.xml file of the consuming app. Meaning that apps the use the permission_handler but don't require the POST_NOTIFICATION permission will end up having it declared in their final AndroidManifest.xml file after compilation.
This should be an explicit choice of the app developer and therefore the app developer should manually add the permission to the AndroidManifest.xml file associated with their application.
Thank you for the clear explanation regarding plugin-level permissions. I completely understand and agree that it makes sense to keep permission declarations explicitly at the app level.
For clarity to other users, it's worth highlighting that developers will encounter build failures or runtime issues related to POST_NOTIFICATIONS if foreground services trigger notifications. They'll need to manually add to their app's AndroidManifest.xml and handle runtime permission requests. I've seen many users encountering "panic-inducing" lint errors during Gradle builds due to this.
Given this, I agree the solution lies with the app developer. You can close this issue. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the 'android.permission.POST_NOTIFICATIONS' permission to the Android manifest. This is required for apps targeting API 33 (Android 13) and above to use NotificationManagerCompat.notify without build failures related to missing permissions.