Fix feedback from PR

Author: mvanbeusekom

backend/zgw/documenten-api-preview/src/main/kotlin/com/ritense/documentenapipreview/client/PdfConversionClient.kt

@@ -46,7 +46,9 @@ class PdfConversionClient(
         val bodyBuilder = MultipartBodyBuilder().apply {
             part("files", InputStreamResource(document)).filename(fileName ?: "file_name_unknown")
             part("exportFormFields", "false")
-            part("pdfa", convertPdfArchiveMethodToGotenbergValue(pdfArchiveMethod))
+            if (pdfArchiveMethod != PdfArchiveMethod.NONE) {
+                part("pdfa", convertPdfArchiveMethodToGotenbergValue(pdfArchiveMethod))
+            }
             if (pdfUniversalAccessibility) {
                 part("pdfua", "true")
             } else {

backend/zgw/documenten-api-preview/src/main/kotlin/com/ritense/documentenapipreview/domain/PdfArchiveMethod.kt

@@ -1,3 +1,19 @@
+/*
+ * Copyright 2015-2024 Ritense BV, the Netherlands.
+ *
+ * Licensed under EUPL, Version 1.2 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://joinup.ec.europa.eu/collection/eupl/eupl-text-eupl-12
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" basis,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 package com.ritense.documentenapipreview.domain
 
 import com.fasterxml.jackson.annotation.JsonProperty

backend/zgw/documenten-api-preview/src/test/kotlin/com/ritense/documentenapipreview/client/PdfConversionClientIT.kt

@@ -19,6 +19,7 @@ package com.ritense.documentenapipreview.client
 import com.fasterxml.jackson.databind.ObjectMapper
 import com.ritense.documentenapipreview.BaseIntegrationTest
 import com.ritense.documentenapipreview.DocumentenApiPreviewPlugin
+import com.ritense.documentenapipreview.domain.PdfArchiveMethod
 import okhttp3.mockwebserver.Dispatcher
 import okhttp3.mockwebserver.MockResponse
 
@@ -67,7 +68,9 @@ internal class PdfConversionClientIT @Autowired constructor(
         val stream = pdfConversionClient.convertDocument(
             documentenApiPreviewPlugin.pdfConversionUrl,
             "test_document".byteInputStream(),
-            "dummy_file.txt"
+            "dummy_file.txt",
+            PdfArchiveMethod.PDFA2B,
+            true
         )
 
         assertNotNull(stream)

frontend/projects/valtimo/plugin/src/lib/plugins/documenten-api-preview/components/documenten-api-preview-configuration/documenten-api-preview-configuration.component.ts

@@ -16,7 +16,7 @@
 
 import {Component, EventEmitter, Input, OnDestroy, OnInit, Output} from '@angular/core';
 import {PluginConfigurationComponent} from '../../../../models';
-import {BehaviorSubject, combineLatest, map, Observable, Subscription, take} from 'rxjs';
+import {BehaviorSubject, combineLatest, map, Observable, skip, Subscription, take} from 'rxjs';
 import {DocumentenApiPreviewConfig} from '../../models';
 import {PluginManagementService, PluginTranslationService} from '../../../../services';
 import {TranslateService} from '@ngx-translate/core';
@@ -46,9 +46,9 @@ export class DocumentenApiPreviewConfigurationComponent
 
   public readonly pdfArchiveMethods: SelectItem[] = [
     {id: 'none', text: 'None', translationKey: 'pdfArchiveMethodNone'},
-    {id: 'PDF/A-1b', text: 'PDF/A-1b', translationKey: 'pdfArchiveMethodPDFA1b'},
-    {id: 'PDF/A-2b', text: 'PDF/A-2b', translationKey: 'pdfArchiveMethodPDFA2b'},
-    {id: 'PDF/A-3b', text: 'PDF/A-3b', translationKey: 'pdfArchiveMethodPDFA3b'},
+    {id: 'PDF/A-1b', text: 'PDF/A-1b', translationKey: 'pdfArchiveMethodPdfA1b'},
+    {id: 'PDF/A-2b', text: 'PDF/A-2b', translationKey: 'pdfArchiveMethodPdfA2b'},
+    {id: 'PDF/A-3b', text: 'PDF/A-3b', translationKey: 'pdfArchiveMethodPdfA3b'},
   ];
 
   public readonly pdfUniversalAccessibility$ = new BehaviorSubject<boolean>(false);
@@ -100,15 +100,20 @@ export class DocumentenApiPreviewConfigurationComponent
   }
 
   private initPdfUniversalAccessibilityEnabled(): void {
-    this.prefillConfiguration$.pipe(take(1)).subscribe(configuration => {
-      this.pdfUniversalAccessibility$.next(configuration.pdfArchiveUniversalAccessibility);
+    this.prefillConfiguration$?.pipe(take(1)).subscribe(configuration => {
+      this.pdfUniversalAccessibility$.next(!!configuration?.pdfUniversalAccessibility);
     });
   }
 
   private openPdfUniversalAccessibilitySubscription(): void {
-    this._pdfUniversalAccessibilitySubscription = this.pdfUniversalAccessibility$.subscribe(value => {
-      this.formValueChange(this.formValue$.getValue())
-    });
+    this._pdfUniversalAccessibilitySubscription = this.pdfUniversalAccessibility$
+      .pipe(skip(1))
+      .subscribe(() => {
+        const currentFormValue = this.formValue$.getValue();
+        if (currentFormValue) {
+          this.formValueChange(currentFormValue);
+        }
+      });
   }
 
   private handleValid(formValue: DocumentenApiPreviewConfig): void {