Skip to content

Commit cc29f37

Browse files
committed
Fix nitpicks from AI feedback
1 parent f398514 commit cc29f37

4 files changed

Lines changed: 8 additions & 6 deletions

File tree

frontend/projects/valtimo/plugin/src/lib/plugins/documenten-api-preview/components/documenten-api-preview-configuration/documenten-api-preview-configuration.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
[disabled]="obs.disabled"
8989
[onText]="'pdfUniversalAccessibility.toggleOn' | pluginTranslate: pluginId | async"
9090
[offText]="'pdfUniversalAccessibility.toggleOff' | pluginTranslate: pluginId | async"
91-
(checkedChange)="onPdfArchiveUniversalAccessibilityChange($event)"
91+
(checkedChange)="onPdfUniversalAccessibilityChange($event)"
9292
></cds-toggle>
9393
</div>
9494
</v-form>

frontend/projects/valtimo/plugin/src/lib/plugins/documenten-api-preview/components/documenten-api-preview-configuration/documenten-api-preview-configuration.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ export class DocumentenApiPreviewConfigurationComponent
8686
this.saveSubscription?.unsubscribe();
8787
}
8888

89-
public onPdfArchiveUniversalAccessibilityChange(event: any): void {
90-
this.pdfUniversalAccessibility$.next(event);
89+
public onPdfUniversalAccessibilityChange(checked: boolean): void {
90+
this.pdfUniversalAccessibility$.next(checked);
9191
}
9292

9393
formValueChange(formValue: DocumentenApiPreviewConfig): void {

frontend/projects/valtimo/plugin/src/lib/plugins/documenten-api-preview/models/config.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@
1616

1717
import {PluginConfigurationData} from '../../../models';
1818

19+
type PdfArchiveMethod = 'none' | 'PDF/A-1b' | 'PDF/A-2b' | 'PDF/A-3b';
20+
1921
interface DocumentenApiPreviewConfig extends PluginConfigurationData {
2022
pdfConversionUrl: string;
2123
documentenApiConfigurationId: string;
22-
pdfArchiveMethod: string;
24+
pdfArchiveMethod: PdfArchiveMethod;
2325
pdfUniversalAccessibility: boolean;
2426
}
2527

frontend/projects/valtimo/zgw/src/lib/modules/documenten-api/components/documenten-api-preview-modal/documenten-api-preview-modal.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ <h3 class="header">
4343
</cds-modal>
4444

4545
<ng-template #loading>
46-
<div class="loading-container">
47-
<span class="cds--inline-notification__title">
46+
<div class="loading-container" role="status" aria-live="polite">
47+
<span class="cds--type-heading-compact-01">
4848
{{ 'zgw.documents.preview.loading' | translate }}
4949
</span>
5050
<cds-loading size="normal"></cds-loading>

0 commit comments

Comments
 (0)