fix: Don't return closed connections to pool#64
Merged
Merged
Conversation
Simplified approach: if connection cleanup fails (connection is closed), don't return it to the pool. This prevents cascading "Connection already closed!" errors on subsequent queries. Note: This will cause the pool to shrink over time if connections are being closed unexpectedly. Need to investigate why connections are being closed in the first place. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified approach: if connection cleanup fails (connection is closed), don't return it to the pool. This prevents cascading "Connection already closed!" errors on subsequent queries.
Note: This will cause the pool to shrink over time if connections are being closed unexpectedly. Need to investigate why connections are being closed in the first place.
🤖 Generated with Claude Code