Skip to content

Commit ab22d21

Browse files
committed
Enhance RTCDataChannel send method to accept multiple data types: string, Blob, ArrayBuffer, and ArrayBufferView
1 parent 82adc1e commit ab22d21

8 files changed

Lines changed: 31 additions & 6 deletions

File tree

baselines/dom.generated.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19799,7 +19799,7 @@ interface RTCDataChannel extends EventTarget {
1979919799
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCDataChannel/close) */
1980019800
close(): void;
1980119801
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCDataChannel/send) */
19802-
send(data: string): void;
19802+
send(data: string | Blob | ArrayBuffer | ArrayBufferView): void;
1980319803
send(data: Blob): void;
1980419804
send(data: ArrayBuffer): void;
1980519805
send(data: ArrayBufferView<ArrayBuffer>): void;

baselines/ts5.5/dom.generated.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19779,7 +19779,7 @@ interface RTCDataChannel extends EventTarget {
1977919779
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCDataChannel/close) */
1978019780
close(): void;
1978119781
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCDataChannel/send) */
19782-
send(data: string): void;
19782+
send(data: string | Blob | ArrayBuffer | ArrayBufferView): void;
1978319783
send(data: Blob): void;
1978419784
send(data: ArrayBuffer): void;
1978519785
send(data: ArrayBufferView): void;

baselines/ts5.5/webworker.generated.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5564,7 +5564,7 @@ interface RTCDataChannel extends EventTarget {
55645564
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCDataChannel/close) */
55655565
close(): void;
55665566
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCDataChannel/send) */
5567-
send(data: string): void;
5567+
send(data: string | Blob | ArrayBuffer | ArrayBufferView): void;
55685568
send(data: Blob): void;
55695569
send(data: ArrayBuffer): void;
55705570
send(data: ArrayBufferView): void;

baselines/ts5.6/dom.generated.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19799,7 +19799,7 @@ interface RTCDataChannel extends EventTarget {
1979919799
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCDataChannel/close) */
1980019800
close(): void;
1980119801
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCDataChannel/send) */
19802-
send(data: string): void;
19802+
send(data: string | Blob | ArrayBuffer | ArrayBufferView): void;
1980319803
send(data: Blob): void;
1980419804
send(data: ArrayBuffer): void;
1980519805
send(data: ArrayBufferView): void;

baselines/ts5.6/webworker.generated.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5564,7 +5564,7 @@ interface RTCDataChannel extends EventTarget {
55645564
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCDataChannel/close) */
55655565
close(): void;
55665566
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCDataChannel/send) */
5567-
send(data: string): void;
5567+
send(data: string | Blob | ArrayBuffer | ArrayBufferView): void;
55685568
send(data: Blob): void;
55695569
send(data: ArrayBuffer): void;
55705570
send(data: ArrayBufferView): void;

baselines/webworker.generated.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5564,7 +5564,7 @@ interface RTCDataChannel extends EventTarget {
55645564
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCDataChannel/close) */
55655565
close(): void;
55665566
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/RTCDataChannel/send) */
5567-
send(data: string): void;
5567+
send(data: string | Blob | ArrayBuffer | ArrayBufferView): void;
55685568
send(data: Blob): void;
55695569
send(data: ArrayBuffer): void;
55705570
send(data: ArrayBufferView<ArrayBuffer>): void;

inputfiles/overridingTypes.jsonc

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2325,6 +2325,22 @@
23252325
"type": "MessageEvent"
23262326
}
23272327
]
2328+
},
2329+
"methods": {
2330+
"method": {
2331+
"send": {
2332+
"signature": {
2333+
"0": {
2334+
"param": [
2335+
{
2336+
"name": "data",
2337+
"overrideType": "string | Blob | ArrayBuffer | ArrayBufferView"
2338+
}
2339+
]
2340+
}
2341+
}
2342+
}
2343+
}
23282344
}
23292345
},
23302346
"RTCIceCandidatePair": {

unittests/files/RTCDataChannel.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
function sendIt (peerConnection: RTCPeerConnection, data: ArrayBufferView | string): void {
2+
const dc = peerConnection.createDataChannel('')
3+
4+
if (typeof data === 'string') {
5+
dc.send(data)
6+
} else {
7+
dc.send(data)
8+
}
9+
}

0 commit comments

Comments
 (0)