cleaned up some code and got rid of the over bearing texts in a few scripts

Author: dooly123

Basis/Packages/com.basis.framework/BasisUI/Menus/Main Menu Providers/SettingsProviderParts/SettingsProviderPerformanceLimits.cs

@@ -3,24 +3,8 @@
 using Basis.Scripts.Avatar;
 using UnityEngine;
 using UnityEngine.UI;
-
-/// <summary>
-/// Settings panel for the opt-in client-side avatar performance limits. Every limit
-/// is a (toggle, slider) pair — the toggle flips <c>UsePerfLimit*</c> on, the slider
-/// sets the corresponding <c>MaxPerf*</c> threshold. All values live in
-/// <see cref="BasisSettingsDefaults"/> and are applied at runtime by
-/// <c>SMModuleAvatarPerformanceLimits</c>, which re-evaluates every currently-loaded
-/// remote avatar when any value changes.
-/// </summary>
 public static class SettingsProviderPerformanceLimits
 {
-    /// <summary>
-    /// The root RectTransform of the currently-built tab. Captured once at tab
-    /// creation and read by the toggle callbacks so flipping a limit on/off can
-    /// trigger a layout rebuild — hiding/showing a slider with <c>SetActive</c>
-    /// drops it out of the layout pass, but LayoutGroups don't re-flow siblings
-    /// until somebody calls <c>LayoutRebuilder.ForceRebuildLayoutImmediate</c>.
-    /// </summary>
     private static RectTransform _layoutRoot;
 
     public static PanelTabPage PerformanceLimitsTab(PanelTabGroup tabGroup)
@@ -33,31 +17,15 @@ public static PanelTabPage PerformanceLimitsTab(PanelTabGroup tabGroup)
         RectTransform container = descriptor.ContentParent;
         BuildPerformanceLimitsContent(container);
 
-        // Use the same tabKey we registered with AddLazyTab — it drives both the
-        // reset button label and the "navigate back to this tab" hop after the
-        // reset. Hardcoded English would show that literal string in JP/NL.
         SettingsProvider.AddResetPageButton(container, "settings.tab.performancelimits", ResetPerformanceLimitDefaults);
 
         descriptor.ForceRebuild();
         return tab;
     }
-
-    /// <summary>
-    /// Builds every performance-limit group + control into <paramref name="container"/>
-    /// without adding a reset button. Used by the standalone tab and by the merged
-    /// Graphics tab so both share one source of truth.
-    /// </summary>
     public static void BuildPerformanceLimitsContent(RectTransform container)
     {
         _layoutRoot = container;
 
-        // Session-only bypass. Lives at the top so it's the first thing users see
-        // when they want to quickly check what an avatar actually looks like
-        // unfiltered. Not wired to BasisSettingsDefaults because it deliberately
-        // doesn't persist — flipping it writes straight to the runtime flag on
-        // BasisAvatarPerformanceLimits, which fires OnBypassChanged and pulls
-        // every affected avatar through the same debounced reconcile as a normal
-        // limit change.
         PanelElementDescriptor bypassGroup =
             PanelElementDescriptor.CreateNew(PanelElementDescriptor.ElementStyles.Group, container);
         bypassGroup.SetTitle(BasisLocalization.Get("settings.perf.sessionBypass.title"));
@@ -71,17 +39,11 @@ public static void BuildPerformanceLimitsContent(RectTransform container)
             BasisAvatarPerformanceLimits.BypassAllLimits = on;
         };
 
-        // Header explanation. Trim limits (animators, lights, particles, trails, lines,
-        // cloth, unity colliders) destroy excess components on remote avatars at load
-        // time and ship on by default. Hard-block limits (triangles, bounds, texture
-        // memory, material slots, bones) fall back to the loading mesh when tripped;
-        // only texture memory is on by default at 512 MB.
         PanelElementDescriptor intro =
             PanelElementDescriptor.CreateNew(PanelElementDescriptor.ElementStyles.Group, container);
         intro.SetTitle(BasisLocalization.Get("settings.perf.intro.title"));
         intro.SetDescription(BasisLocalization.Get("settings.perf.intro.description"));
 
-        // ---------------- Geometry ----------------
         PanelElementDescriptor geometry =
             PanelElementDescriptor.CreateNew(PanelElementDescriptor.ElementStyles.Group, container);
         geometry.SetTitle(BasisLocalization.Get("settings.perf.group.geometry"));
@@ -94,28 +56,20 @@ public static void BuildPerformanceLimitsContent(RectTransform container)
             BasisSettingsDefaults.MaxPerfTriangles,
             1000, 2_000_000, true, displayMode: ValueDisplayMode.Compact);
 
-        // Minimum starts at 10 m — anything smaller rejects a normal humanoid on
-        // principle, and the bounds check is there to catch 50 m-tall monster
-        // bundles rather than tune small avatars.
         AddLimitPair(geometry.ContentParent,
             BasisLocalization.Get("settings.perf.boundsSize.toggle"),
             BasisLocalization.Get("settings.perf.boundsSize.slider"),
             BasisSettingsDefaults.UsePerfLimitBoundsSize,
             BasisSettingsDefaults.MaxPerfBoundsSize,
             10f, 50f, false, decimals: 1);
 
-        // Hard-block cap. Intended as a guard rail for pathological bundles rather
-        // than a daily driver — label reflects that so users don't set it low.
-        // "per avatar" is explicit because bones is the one limit where users
-        // reasonably ask whether it sums across the room or counts per-player.
         AddLimitPair(geometry.ContentParent,
             BasisLocalization.Get("settings.perf.bones.toggle"),
             BasisLocalization.Get("settings.perf.bones.slider"),
             BasisSettingsDefaults.UsePerfLimitBones,
             BasisSettingsDefaults.MaxPerfBones,
             16, 16384, true, displayMode: ValueDisplayMode.Compact);
 
-        // ---------------- Meshes & Materials ----------------
         PanelElementDescriptor meshes =
             PanelElementDescriptor.CreateNew(PanelElementDescriptor.ElementStyles.Group, container);
         meshes.SetTitle(BasisLocalization.Get("settings.perf.group.meshesMaterials"));
@@ -148,7 +102,6 @@ public static void BuildPerformanceLimitsContent(RectTransform container)
             BasisSettingsDefaults.MaxPerfTextureMemoryMB,
             8, 4096, true);
 
-        // ---------------- Physics ----------------
         PanelElementDescriptor physics =
             PanelElementDescriptor.CreateNew(PanelElementDescriptor.ElementStyles.Group, container);
         physics.SetTitle(BasisLocalization.Get("settings.perf.group.physics"));
@@ -160,15 +113,6 @@ public static void BuildPerformanceLimitsContent(RectTransform container)
             BasisSettingsDefaults.MaxPerfJiggleBones,
             0, 128, true);
 
-        // JiggleColliderExample is not in AvatarContentPoliceSelector.asset, so the
-        // content police strips every instance at load time before this limit could
-        // ever run. Surface nothing for it in the UI.
-        // AddLimitPair(physics.ContentParent,
-        //     "Limit Jiggle Colliders", "Max Jiggle Colliders",
-        //     BasisSettingsDefaults.UsePerfLimitJiggleColliders,
-        //     BasisSettingsDefaults.MaxPerfJiggleColliders,
-        //     0, 64, true);
-
         AddLimitPair(physics.ContentParent,
             BasisLocalization.Get("settings.perf.colliders.toggle"),
             BasisLocalization.Get("settings.perf.colliders.slider"),
@@ -183,21 +127,10 @@ public static void BuildPerformanceLimitsContent(RectTransform container)
             BasisSettingsDefaults.MaxPerfCloth,
             0, 16, true);
 
-        // ---------------- Effects ----------------
         PanelElementDescriptor effects =
             PanelElementDescriptor.CreateNew(PanelElementDescriptor.ElementStyles.Group, container);
         effects.SetTitle(BasisLocalization.Get("settings.perf.group.effects"));
 
-        // UnityEngine.Light is not in AvatarContentPoliceSelector.asset, so the
-        // content police strips every Light on a downloaded remote avatar before
-        // this limit could ever run. Addressable (in-build) avatars are curated,
-        // so lights there are effectively impossible too. Surface nothing for it.
-        // AddLimitPair(effects.ContentParent,
-        //     "Limit Lights", "Max Lights",
-        //     BasisSettingsDefaults.UsePerfLimitLights,
-        //     BasisSettingsDefaults.MaxPerfLights,
-        //     0, 32, true);
-
         AddLimitPair(effects.ContentParent,
             BasisLocalization.Get("settings.perf.particleSystems.toggle"),
             BasisLocalization.Get("settings.perf.particleSystems.slider"),
@@ -219,7 +152,6 @@ public static void BuildPerformanceLimitsContent(RectTransform container)
             BasisSettingsDefaults.MaxPerfLineRenderers,
             0, 64, true);
 
-        // ---------------- Runtime ----------------
         PanelElementDescriptor runtime =
             PanelElementDescriptor.CreateNew(PanelElementDescriptor.ElementStyles.Group, container);
         runtime.SetTitle(BasisLocalization.Get("settings.perf.group.runtime"));
@@ -232,30 +164,15 @@ public static void BuildPerformanceLimitsContent(RectTransform container)
             BasisSettingsDefaults.MaxPerfAnimators,
             1, 32, true);
 
-        // Cilbox script behaviours: each CilboxProxy on a remote avatar is one
-        // sandboxed MonoBehaviour with its own per-frame Update/FixedUpdate tick.
         AddLimitPair(runtime.ContentParent,
             BasisLocalization.Get("settings.perf.cilboxBehaviours.toggle"),
             BasisLocalization.Get("settings.perf.cilboxBehaviours.slider"),
             BasisSettingsDefaults.UsePerfLimitCilboxBehaviours,
             BasisSettingsDefaults.MaxPerfCilboxBehaviours,
             0, 64, true);
 
-        // ---------------- Content Tags ----------------
-        // Sits at the bottom of the same tab so users see content-safety filters
-        // alongside perf filters — same mental model ("block this avatar before it
-        // loads"), different criteria (creator-declared category vs. measured cost).
         SettingsProviderContentTags.BuildContentTagsContent(container);
     }
-
-    /// <summary>
-    /// Adds a toggle and slider for a single limit. The toggle controls whether the
-    /// limit is enforced; the slider sets the threshold. When the toggle is off the
-    /// slider's entire GameObject is hidden so the settings panel only shows the
-    /// knob for an active limit — matches how VRChat / NeosVR hide inactive options.
-    /// <paramref name="displayMode"/> lets large-number sliders (triangles, bones)
-    /// opt into the compact "1k / 32.5k / 2M" readout instead of raw integers.
-    /// </summary>
     private static void AddLimitPair(
         Component parent,
         string toggleTitle,
@@ -272,18 +189,8 @@ private static void AddLimitPair(
         toggle.Descriptor.SetTitle(toggleTitle);
         toggle.AssignBinding(useBinding);
 
-        PanelSlider slider = PanelSlider.CreateEntryAndBind(
-            parent,
-            PanelSlider.SliderSettings.Advanced(sliderTitle, sliderMin, sliderMax, wholeNumbers, decimals, displayMode),
-            maxBinding);
-
-        // Seed visibility from the saved toggle state, then keep it in sync whenever
-        // the binding flips — including programmatic changes like the reset button.
-        // SetActive on the slider GameObject removes it from the layout pass entirely
-        // so the container re-flows and only active limits take up vertical space;
-        // LayoutRebuilder.ForceRebuildLayoutImmediate is what actually closes / reopens
-        // the gap. PanelToggle.OnValueChanged only fires from user-driven SetValue,
-        // so we hook BasisSettingsBinding.OnChanged here to also catch resets.
+        PanelSlider slider = PanelSlider.CreateEntryAndBind(parent, PanelSlider.SliderSettings.Advanced(sliderTitle, sliderMin, sliderMax, wholeNumbers, decimals, displayMode), maxBinding);
+
         if (slider != null)
         {
             void Sync(bool on)

Basis/Packages/com.basis.framework/IK/BasisAnimationRiggingHelper.cs

@@ -17,60 +17,41 @@ public static void CreateBasisFullBodyRIG(BasisLocalPlayer player, GameObject pa
         // Holder + component
         var go = CreateAndSetParent(parent.transform, $"Full IK ({parent.name})");
         BasisFullIKConstraint = BasisHelpers.GetOrAddComponent<BasisFullBodyIK>(go);
-
-        // ----------------------------
-        // Core: grab data (local copy)
-        // ----------------------------
         var data = BasisFullIKConstraint.data;
-
-        // ----------------------------
-        // Skeleton references
-        // ----------------------------
         // Torso / head chain
         data.hips = Mapping.Hips;
         data.spine = Mapping.spine;
         data.chest = Mapping.chest;
         data.upperChest = Mapping.Upperchest;
         data.neck = Mapping.neck;
         data.head = Mapping.head;
-
         // Shoulders
         data.LeftShoulder = Mapping.leftShoulder;
         data.RightShoulder = Mapping.RightShoulder;
-
         // Arms
         data.leftUpperArm = Mapping.leftUpperArm;
         data.leftLowerArm = Mapping.leftLowerArm;
         data.LeftHand = Mapping.leftHand;
         data.RightUpperArm = Mapping.RightUpperArm;
         data.RightLowerArm = Mapping.RightLowerArm;
         data.RightHand = Mapping.rightHand;
-
         // Optional twist bones (auto-detected from rig hierarchy; null when not present)
         data.LeftUpperArmTwist = Mapping.leftUpperArmTwist;
         data.LeftLowerArmTwist = Mapping.leftLowerArmTwist;
         data.RightUpperArmTwist = Mapping.RightUpperArmTwist;
         data.RightLowerArmTwist = Mapping.RightLowerArmTwist;
-
         // Legs
         data.LeftUpperLeg = Mapping.LeftUpperLeg;
         data.LeftLowerLeg = Mapping.LeftLowerLeg;
         data.leftFoot = Mapping.leftFoot;
-
         data.RightUpperLeg = Mapping.RightUpperLeg;
         data.RightLowerLeg = Mapping.RightLowerLeg;
         data.RightFoot = Mapping.rightFoot;
-
         // Toes
         data.LeftToe = Mapping.leftToe;
         data.RightToe = Mapping.rightToe;
-
-        // ----------------------------
-        // Calibration defaults
-        // ----------------------------
         // Head
         data.m_CalibratedRotationHead = Mapping.Hashead ? Mapping.head.rotation : Quaternion.identity;
-
         // Feet
         data.M_CalibrationLeftFootRotation = Mapping.Hashead ? Mapping.leftFoot.rotation : Quaternion.identity;
         data.M_CalibrationRightFootRotation = Mapping.Hashead ? Mapping.rightFoot.rotation : Quaternion.identity;
@@ -114,11 +95,6 @@ public static void CreateBasisFullBodyRIG(BasisLocalPlayer player, GameObject pa
         data.m_CalibratedRotationRightShoulder = Mapping.HasRightShoulder ? Mapping.RightShoulder.rotation : Quaternion.identity;
         // Hips reference rotation
         data.OffsetRotationHips = Mapping.HasHips ? Mapping.Hips.rotation : Quaternion.identity;
-
-
-        // ----------------------------
-        // Targets & hints
-        // ----------------------------
         // Head
         data.PositionHead = BasisLocalBoneDriver.HeadControl.OutgoingWorldData.position;
         data.RotationHead = BasisLocalBoneDriver.HeadControl.OutgoingWorldData.rotation;
@@ -145,30 +121,25 @@ public static void CreateBasisFullBodyRIG(BasisLocalPlayer player, GameObject pa
         // Cache world data once per control (less property spam, easier to read)
         var leftLowerArm = BasisLocalBoneDriver.LeftLowerArmControl.OutgoingWorldData;
         var rightLowerArm = BasisLocalBoneDriver.RightLowerArmControl.OutgoingWorldData;
-
         var chest = BasisLocalBoneDriver.ChestControl.OutgoingWorldData;
-
         var leftLowerLeg = BasisLocalBoneDriver.LeftLowerLegControl.OutgoingWorldData;
         var rightLowerLeg = BasisLocalBoneDriver.RightLowerLegControl.OutgoingWorldData;
-
         var leftShoulder = BasisLocalBoneDriver.LeftShoulderControl.OutgoingWorldData;
         var rightShoulder = BasisLocalBoneDriver.RightShoulderControl.OutgoingWorldData;
 
         // --- Arms ---
         data.LeftLowerArmPosition = BasisLocalRigDriver.ApplyHintBias(Basis.Scripts.TransformBinders.BoneControl.BasisBoneTrackedRole.LeftLowerArm, leftLowerArm.position, leftLowerArm.rotation);
         data.LeftLowerArmRotation = leftLowerArm.rotation;
-
         data.RightLowerArmPosition = BasisLocalRigDriver.ApplyHintBias(Basis.Scripts.TransformBinders.BoneControl.BasisBoneTrackedRole.RightLowerArm, rightLowerArm.position, rightLowerArm.rotation);
         data.RightLowerArmRotation = rightLowerArm.rotation;
 
-        // --- Shoulders (rotation only in your data model) ---
+        // --- Shoulders ---
         data.LeftShoulderRotation = leftShoulder.rotation;
         data.RightShoulderRotation = rightShoulder.rotation;
 
         // --- Legs ---
         data.PositionLeftLowerLeg = BasisLocalRigDriver.ApplyHintBias(Basis.Scripts.TransformBinders.BoneControl.BasisBoneTrackedRole.LeftLowerLeg, leftLowerLeg.position, leftLowerLeg.rotation);
         data.RotationLeftLowerLeg = leftLowerLeg.rotation;
-
         data.PositionRightLowerLeg = BasisLocalRigDriver.ApplyHintBias(Basis.Scripts.TransformBinders.BoneControl.BasisBoneTrackedRole.RightLowerLeg, rightLowerLeg.position, rightLowerLeg.rotation);
         data.RotationRightLowerLeg = rightLowerLeg.rotation;
 
@@ -200,18 +171,22 @@ public static void CreateBasisFullBodyRIG(BasisLocalPlayer player, GameObject pa
     private static (bool valid, Vector3 pos) GetLM(Transform[] arr, int i)
     {
         if (arr != null && i >= 0 && i < arr.Length && arr[i] != null)
+        {
             return (true, arr[i].position);
+        }
 
         return (false, Vector3.zero);
     }
     private static Quaternion ComputeHandRotationWithFallback( Vector3 wrist,(bool valid, Vector3 pos)[] pointsA,(bool valid, Vector3 pos)[] pointsB, ref bool hasLast, ref Quaternion lastRot)
     {
-        // pointsA[i] pairs with pointsB[i] as a candidate
-        for (int i = 0; i < pointsA.Length; i++)
+        for (int Index = 0; Index < pointsA.Length; Index++)
         {
-            if (!pointsA[i].valid || !pointsB[i].valid) continue;
+            if (!pointsA[Index].valid || !pointsB[Index].valid)
+            {
+                continue;
+            }
 
-            Quaternion rot = HandRotationFromLandmarks(wrist, pointsA[i].pos, pointsB[i].pos);
+            Quaternion rot = HandRotationFromLandmarks(wrist, pointsA[Index].pos, pointsB[Index].pos);
             if (rot == Quaternion.identity) continue;
 
             lastRot = rot;
@@ -240,10 +215,7 @@ public static Quaternion HandRotationFromLandmarks(Vector3 wrist, Vector3 indexM
         {
             return Quaternion.identity;
         }
-
         up.Normalize();
-        right = Vector3.Cross(up, forward).normalized;
-
         return Quaternion.LookRotation(forward, up);
     }
     public static void GeneratedRequiredTransforms(BasisLocalPlayer player,Transform baseLevel)

Basis/Packages/com.basis.framework/IK/BasisArmBendLookup.cs

@@ -1,6 +1,5 @@
 using System.Runtime.CompilerServices;
 using Unity.Collections;
-using UnityEngine;
 
 namespace UnityEngine.Animations.Rigging
 {
@@ -38,9 +37,6 @@ public static Vector3[] GenerateDefaultTable(bool isLeft)
 
                 // Default bend direction heuristics (from HVR-IK's multi-factor approach):
                 Vector3 bendDir;
-
-                // How much the hand is outward vs inward
-                float outwardness = Mathf.Clamp01(isLeft ? -x : x);
                 // How much the hand is forward
                 float forwardness = Mathf.Clamp01(z);
                 // How much the hand is above