fixed a time bug

Author: dooly123

Basis/Packages/com.basis.framework/BasisUI/Menus/Main Menu Providers/UserListProvider.cs

@@ -4,6 +4,7 @@
 using Basis.Scripts.Networking.NetworkedAvatar;
 using System;
 using System.Collections.Generic;
+using Unity.Mathematics;
 using UnityEngine;
 using UnityEngine.UI;
 
@@ -542,9 +543,9 @@ private static Vector3 GetRemotePosition(BasisPlayer p)
                 return p.transform.position;
             }
 
-            private static string FormatJoinedAgo(float joinTime)
+            private static string FormatJoinedAgo(double joinTime)
             {
-                float ago = Mathf.Max(0f, Time.realtimeSinceStartup - joinTime);
+                float ago = (float)math.max(0f, Time.realtimeSinceStartupAsDouble - joinTime);
                 if (ago < 60f)
                     return BasisLocalization.Get("menu.players.joinedAgoSeconds", Mathf.FloorToInt(ago));
                 if (ago < 3600f)

Basis/Packages/com.basis.framework/Networking/BasisNetworkPlayer.cs

@@ -114,7 +114,7 @@ public ushort get_playerId()
         /// Used to sort the players UI by arrival order and to display "joined Xs ago".
         /// Captured here because the server doesn't send a join timestamp.
         /// </summary>
-        public float JoinTime = Time.realtimeSinceStartup;
+        public double JoinTime = Time.realtimeSinceStartupAsDouble;
         public Dictionary<byte, ServerAvatarDataMessageQueue> NextMessages = new Dictionary<byte, ServerAvatarDataMessageQueue>();
         public struct ServerAvatarDataMessageQueue
         {

Basis/Packages/com.basis.framework/Networking/IServerDirectorySource.cs

@@ -55,7 +55,11 @@ public static void Register(IServerDirectorySource source)
 
         public static void Unregister(string sourceId)
         {
-            if (string.IsNullOrEmpty(sourceId)) return;
+            if (string.IsNullOrEmpty(sourceId))
+            {
+                return;
+            }
+
             bool removed = false;
             lock (_lock)
             {
@@ -68,7 +72,11 @@ public static void Unregister(string sourceId)
                     }
                 }
             }
-            if (!removed) return;
+            if (!removed)
+            {
+                return;
+            }
+
             try { SourcesChanged?.Invoke(); }
             catch (Exception ex) { BasisDebug.LogError($"SourcesChanged handler threw: {ex.Message}"); }
         }

Basis/Packages/com.basis.framework/Networking/SavedServerStore.cs

@@ -54,15 +54,34 @@ public static List<SavedServerEntry> Load()
             try
             {
                 string path = Path.Combine(Application.persistentDataPath, FileName);
-                if (!File.Exists(path)) return new List<SavedServerEntry>();
+                if (!File.Exists(path))
+                {
+                    return new List<SavedServerEntry>();
+                }
+
                 string json = File.ReadAllText(path);
                 SavedServerListWrapper wrapper = JsonUtility.FromJson<SavedServerListWrapper>(json);
-                if (wrapper == null || wrapper.Entries == null) return new List<SavedServerEntry>();
+                if (wrapper == null || wrapper.Entries == null)
+                {
+                    return new List<SavedServerEntry>();
+                }
+
                 foreach (SavedServerEntry e in wrapper.Entries)
                 {
-                    if (e == null) continue;
-                    if (string.IsNullOrEmpty(e.Id)) e.Id = Guid.NewGuid().ToString("N");
-                    if (e.Port == 0) e.Port = 4296;
+                    if (e == null)
+                    {
+                        continue;
+                    }
+
+                    if (string.IsNullOrEmpty(e.Id))
+                    {
+                        e.Id = Guid.NewGuid().ToString("N");
+                    }
+
+                    if (e.Port == 0)
+                    {
+                        e.Port = 4296;
+                    }
                 }
                 return wrapper.Entries;
             }
@@ -93,8 +112,6 @@ public static void Save(List<SavedServerEntry> entries)
         /// and the Server-typed content-share orb so they all parse identically.
         /// Returns false if the address segment ends up empty.
         /// </summary>
-        public static bool TryParseConnectionString(
-            string raw, out string address, out ushort port, out bool portProvided, out string password)
-            => LNLConnectionTargetParser.TryParseConnectionString(raw, out address, out port, out portProvided, out password);
+        public static bool TryParseConnectionString(string raw, out string address, out ushort port, out bool portProvided, out string password) => LNLConnectionTargetParser.TryParseConnectionString(raw, out address, out port, out portProvided, out password);
     }
 }

Basis/Packages/com.basis.framework/Networking/SavedServersDirectorySource.cs

@@ -26,7 +26,11 @@ public sealed class SavedServersDirectorySource : IServerDirectorySource
 
         public static void Initialize()
         {
-            if (Instance != null) return;
+            if (Instance != null)
+            {
+                return;
+            }
+
             Instance = new SavedServersDirectorySource();
             BasisServerDirectoryRegistry.Register(Instance);
         }
@@ -93,7 +97,6 @@ private ServerDirectoryEntry BuildEntry(SavedServerEntry s)
             };
         }
 
-        public static bool IsDefaultEntryId(string id)
-            => string.Equals(id, DefaultServerId, StringComparison.OrdinalIgnoreCase);
+        public static bool IsDefaultEntryId(string id) => string.Equals(id, DefaultServerId, StringComparison.OrdinalIgnoreCase);
     }
 }