Skip to content

Commit 3aa7012

Browse files
committed
refactor(mediaplayer): remove the one-shot VP9 Ycbcr format log
Diagnostic-only, not needed in shipped code. The formatFeatures-gated chroma/sampler filter fix it sat beside is unchanged. Android arm64 .so rebuilt to match.
1 parent 772b21f commit 3aa7012

2 files changed

Lines changed: 0 additions & 11 deletions

File tree

Basis/Packages/com.basis.mediaplayer/Native~/android/basis_android_vk.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -288,17 +288,6 @@ static int ensure_format_objects(basis_vk_present* v, uint64_t externalFormat,
288288
if (yf == VK_FILTER_LINEAR && !linearSample) yf = VK_FILTER_NEAREST;
289289
samplerFilter = yf;
290290
}
291-
/* Diagnostic (once per distinct external format): the buffer's own format
292-
* description. Compares e.g. VP9 (UBWC 0x7fa30c06) vs H.264 to pin down the
293-
* green-corruption cause on-device — does the format advertise linear chroma,
294-
* does the driver return a concrete VkFormat, what model/range does it want. */
295-
__android_log_print(ANDROID_LOG_INFO, "basis_media",
296-
"vk ycbcr fmt: ext=0x%llx vkfmt=%d features=0x%x model=%d range=%d xoff=%d yoff=%d chroma=%s sampler=%s",
297-
(unsigned long long)externalFormat, (int)fmt->format, (unsigned)features,
298-
(int)fmt->suggestedYcbcrModel, (int)fmt->suggestedYcbcrRange,
299-
(int)fmt->suggestedXChromaOffset, (int)fmt->suggestedYChromaOffset,
300-
yf == VK_FILTER_LINEAR ? "linear" : "nearest",
301-
samplerFilter == VK_FILTER_LINEAR ? "linear" : "nearest");
302291
VkSamplerYcbcrConversionCreateInfo cy = { VK_STRUCTURE_TYPE_SAMPLER_YCBCR_CONVERSION_CREATE_INFO };
303292
cy.pNext = &extFmt;
304293
cy.format = VK_FORMAT_UNDEFINED;
Binary file not shown.

0 commit comments

Comments
 (0)