improved validation

Author: dooly123

Basis/Packages/com.basis.framework/Players/Common/BasisPlayerSettingsManager.cs

@@ -56,27 +56,33 @@ public static async Task<BasisPlayerSettingsData> RequestPlayerSettings(string u
             {
                 var json = await File.ReadAllTextAsync(path);
 
-                data = default;
+                BasisPlayerSettingsData loaded = default;
+                bool valid = false;
                 if (!string.IsNullOrWhiteSpace(json))
                 {
                     try
                     {
-                        data = JsonUtility.FromJson<BasisPlayerSettingsData>(json);
+                        loaded = JsonUtility.FromJson<BasisPlayerSettingsData>(json);
+                        valid = loaded.Version != 0;
                     }
                     catch (Exception e)
                     {
                         BasisDebug.LogWarning($"Player settings at {path} were unreadable ({e.Message}); resetting to defaults.");
                     }
                 }
 
-                if (data.Version == 0)
+                if (valid)
                 {
-                    data = CreateDefaults(uuid);
-                    await SaveInternal(path, data);
+                    data = loaded;
+                    if (string.IsNullOrEmpty(data.UUID))
+                    {
+                        data.UUID = uuid;
+                    }
                 }
-                else if (string.IsNullOrEmpty(data.UUID))
+                else
                 {
-                    data.UUID = uuid;
+                    data = CreateDefaults(uuid);
+                    await SaveInternal(path, data);
                 }
             }