Skip to content

Commit 567901a

Browse files
committed
style(trackerobjects): drop internal modifiers and accessor-pair on Bindings
Aligns with the project's STYLE.md preference for plain public fields: - BasisTrackerBinding's bookkeeping fields (PickupRef, RigidRef, PreBindKinematic, HasKinematicCaptured) move from internal to public. - BasisTrackerObjectManager.Bindings drops the get-only auto-property in favour of a public static readonly field — same read-only-ref semantics, no property accessor cost, no walling-off ceremony. - REQUIREMENTS.md spec line updated to match.
1 parent b548c9e commit 567901a

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

Basis/Packages/com.basis.trackerobjects/REQUIREMENTS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public static class BasisTrackerObjectManager
4646
{
4747
public const int RenderPriority = 99;
4848

49-
public static List<BasisTrackerBinding> Bindings { get; }
49+
public static readonly List<BasisTrackerBinding> Bindings;
5050

5151
public static event Action<BasisTrackerBinding> OnBindingCreated;
5252
public static event Action<BasisTrackerBinding> OnBindingRemoved;

Basis/Packages/com.basis.trackerobjects/Runtime/BasisTrackerBinding.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ public class BasisTrackerBinding
1414
public Vector3 LocalPositionOffset;
1515
public Quaternion LocalRotationOffset;
1616

17-
internal BasisPickupInteractable PickupRef;
18-
internal Rigidbody RigidRef;
19-
internal bool PreBindKinematic;
20-
internal bool HasKinematicCaptured;
17+
public BasisPickupInteractable PickupRef;
18+
public Rigidbody RigidRef;
19+
public bool PreBindKinematic;
20+
public bool HasKinematicCaptured;
2121
}
2222
}

Basis/Packages/com.basis.trackerobjects/Runtime/BasisTrackerObjectManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public static class BasisTrackerObjectManager
1111
{
1212
public const int RenderPriority = 99;
1313

14-
public static List<BasisTrackerBinding> Bindings { get; } = new List<BasisTrackerBinding>();
14+
public static readonly List<BasisTrackerBinding> Bindings = new List<BasisTrackerBinding>();
1515

1616
public static event Action<BasisTrackerBinding> OnBindingCreated;
1717
public static event Action<BasisTrackerBinding> OnBindingRemoved;

0 commit comments

Comments
 (0)