further changes to the event driver and related calls

Author: dooly123

Basis/Packages/com.basis.eventdriver/BasisEventDriver.cs

@@ -176,7 +176,7 @@ public void Update()
             }
 
             OSCAcquisitionServer.Simulate();
-            SMModuleAvatarPerformanceLimits.SimulateDebounce();
+            SMModuleAvatarPerformanceLimits.Simulate();
             timeSinceLastUpdate += DeltaTime;
         }
 
@@ -226,7 +226,6 @@ public void LateUpdate()
 
             // ── Device management ──
             ProfileBegin(PROF_DEVICE_MANAGEMENT);
-            BasisDeviceManagement.OnDeviceManagementLoop?.Invoke();
             if (BasisDeviceManagement.HasEvents)
             {
                 BasisDeviceManagement.Instance.Simulate();
@@ -242,8 +241,8 @@ public void LateUpdate()
             ProfileBegin(PROF_LOCAL_PLAYER);
             if (BasisLocalPlayer.PlayerReady)
             {
-                var LocalCameraDriver = BasisLocalCameraDriver.Instance;
-                var localplayer = BasisLocalPlayer.Instance;
+                BasisLocalCameraDriver LocalCameraDriver = BasisLocalCameraDriver.Instance;
+                BasisLocalPlayer localplayer = BasisLocalPlayer.Instance;
                 localplayer.FacialBlinkDriver.Simulate(TimeAsDouble);
                 localplayer.LocalVisemeDriver.Apply();
                 localplayer.Simulate(DeltaTime);

Basis/Packages/com.basis.framework/Device Management/BasisDeviceManagement.cs

@@ -259,6 +259,7 @@ private async void OnDestroy()
         }
         public void Simulate()
         {
+            OnDeviceManagementLoop?.Invoke();
             int Count = BaseTypes.Count;
             for (int Index = 0; Index < Count; Index++)
             {

Basis/Packages/com.basis.framework/Drivers/Local/BasisLocalMicrophoneDriver.cs

@@ -456,13 +456,23 @@ public static void MicrophoneUpdate()
 
         int currentPosition = Microphone.GetPosition(MicrophoneDevice);
         position = currentPosition;
-        if (position <= 0) return;
+        if (position <= 0)
+        {
+            return;
+        }
 
         int clipFrames = clip.samples;
-        if (clipFrames <= 0) return;
+        if (clipFrames <= 0)
+        {
+            return;
+        }
 
         int ch = clip.channels;
-        if (ch < 1) ch = 1;
+        if (ch < 1)
+        {
+            ch = 1;
+        }
+
         channels = ch;
 
         // Clamp to min(bufferLength, clipFrames) so a device restart that produced a
@@ -471,15 +481,16 @@ public static void MicrophoneUpdate()
         LocalOpusSettings.CreateOrResizeArray(framesToUse, ref microphoneBufferArray);
 
         int dataLength = GetDataLength(framesToUse, head, position);
-        if (dataLength < ProcessFrameSize) return;
+        if (dataLength < ProcessFrameSize)
+        {
+            return;
+        }
 
-        // Pull only the new region [head .. head+dataLength) from the clip, in fixed
-        // chunks of one process frame. Each chunk is downmixed into the mono ring at
-        // its matching ring positions. Replaces a previous full-clip GetData per tick
-        // (~192 KB → ~3.8 KB per chunk for mono).
         int chunkInterleaved = ProcessFrameSize * channels;
         if (_micDelta == null || _micDelta.Length != chunkInterleaved)
+        {
             _micDelta = new float[chunkInterleaved];
+        }
 
         // Serialize ring-buffer writes against the bg processor reading the same
         // region and advancing `head`. Without the lock, ProcessAudioData can read
@@ -500,9 +511,13 @@ public static void MicrophoneUpdate()
         processingEvent.Set();
 
         if (Interlocked.Exchange(ref _scheduleMainHasAudio, 0) == 1)
+        {
             MainThreadOnHasAudio?.Invoke();
+        }
         else if (Interlocked.Exchange(ref _scheduleMainHasSilence, 0) == 1)
+        {
             MainThreadOnHasSilence?.Invoke();
+        }
     }
 
     /// <summary>
@@ -512,16 +527,26 @@ public static void MicrophoneUpdate()
     /// </summary>
     private static void DownmixDeltaIntoRingMono(int headFrame, int frameCount, int ringFrames, int ch, float[] srcDelta, float[] dstMono)
     {
-        if (srcDelta == null || dstMono == null || frameCount <= 0) return;
-        if (ch < 1) ch = 1;
+        if (srcDelta == null || dstMono == null || frameCount <= 0)
+        {
+            return;
+        }
+
+        if (ch < 1)
+        {
+            ch = 1;
+        }
 
         int firstFrames = Mathf.Min(frameCount, ringFrames - headFrame);
 
         if (ch == 1)
         {
             Array.Copy(srcDelta, 0, dstMono, headFrame, firstFrames);
             if (firstFrames < frameCount)
+            {
                 Array.Copy(srcDelta, firstFrames, dstMono, 0, frameCount - firstFrames);
+            }
+
             return;
         }
 

Basis/Packages/com.basis.framework/Networking/BasisRemoteFaceManagement.cs

@@ -132,36 +132,36 @@ public static void Simulate(double t, float dt)
             byte* pUse = (byte*)useJobEye.GetUnsafePtr();
             byte* pLastHas = (byte*)lastHasEyeBones.GetUnsafePtr();
 
-            for (int i = 0; i < count; i++)
+            for (int Index = 0; Index < count; Index++)
             {
-                BasisNetworkReceiver receiver = snapshot[i];
+                BasisNetworkReceiver receiver = snapshot[Index];
                 BasisRemoteFaceDriver Face = receiver.RemotePlayer.RemoteFaceDriver;
 
-                bool slotChanged = i >= lastBuiltCount
-                    || !ReferenceEquals(faceCache[i], Face)
-                    || lastFaceGen[i] != Face.FaceGeneration;
+                bool slotChanged = Index >= lastBuiltCount
+                    || !ReferenceEquals(faceCache[Index], Face)
+                    || lastFaceGen[Index] != Face.FaceGeneration;
 
                 if (slotChanged)
                 {
                     bool hasValidEyeBones = Face.HasEyeBones
                         && Face.LeftEyeTransform != null
                         && Face.RightEyeTransform != null;
 
-                    faceCache[i] = Face;
-                    eyesCache[i] = receiver.EyesAndMouth;
-                    lastFaceGen[i] = Face.FaceGeneration;
-                    pLastHas[i] = hasValidEyeBones ? (byte)1 : (byte)0;
+                    faceCache[Index] = Face;
+                    eyesCache[Index] = receiver.EyesAndMouth;
+                    lastFaceGen[Index] = Face.FaceGeneration;
+                    pLastHas[Index] = hasValidEyeBones ? (byte)1 : (byte)0;
 
                     // Blit on eye-bone presence, not useJob, so calibration is ready when OverrideEye later clears.
                     if (hasValidEyeBones)
                     {
-                        pCalL[i] = new EyeCalibrationBlit
+                        pCalL[Index] = new EyeCalibrationBlit
                         {
                             basis = Face.calLeft.basis,
                             invBasis = Face.calLeft.invBasis,
                             initialRotation = Face.calLeft.initialRotation,
                         };
-                        pCalR[i] = new EyeCalibrationBlit
+                        pCalR[Index] = new EyeCalibrationBlit
                         {
                             basis = Face.calRight.basis,
                             invBasis = Face.calRight.invBasis,
@@ -172,7 +172,7 @@ public static void Simulate(double t, float dt)
                     needRebuild = true;
                 }
 
-                pUse[i] = (pLastHas[i] != 0 && !Face.OverrideEye) ? (byte)1 : (byte)0;
+                pUse[Index] = (pLastHas[Index] != 0 && !Face.OverrideEye) ? (byte)1 : (byte)0;
             }
         }
 

Basis/Packages/com.basis.framework/Settings/SMModuleAvatarPerformanceLimits.cs

@@ -33,7 +33,7 @@ private static void OnTagFilterChanged()
     {
         ScheduleReconcile();
     }
-    public static void SimulateDebounce()
+    public static void Simulate()
     {
         if (RequiresPerformanceCheck != false)
         {

Basis/Packages/com.basis.framework/UI/NamePlate/BasisRemoteNamePlateDriver.cs

@@ -732,7 +732,9 @@ public static void ScheduleSimulate(double now)
             ProcessBakeQueue();
 
             if (!ShouldRunJobs())
+            {
                 return;
+            }
 
             ScheduleSimulate(now, returnDelay, transitionDuration, NormalColorFloat4);
         }
@@ -748,7 +750,9 @@ public static void ScheduleSimulate(double now, float hold, float fade, float4 n
         {
             // If a job is still running, don't stomp buffers.
             if (jobScheduled && !handle.IsCompleted)
+            {
                 return;
+            }
 
             // If it finished, complete it now so we can apply structural changes/resizes safely.
             if (jobScheduled)
@@ -758,10 +762,14 @@ public static void ScheduleSimulate(double now, float hold, float fade, float4 n
             }
 
             if (pendingRemove.Count > 0 || pendingAdd.Count > 0)
+            {
                 ApplyPendingStructuralChanges();
+            }
 
             if (count == 0)
+            {
                 return;
+            }
 
             EnsureCapacity(count);