Skip to content

Commit e990653

Browse files
committed
found a issue with our debounce over time
1 parent 85536b3 commit e990653

2 files changed

Lines changed: 13 additions & 6 deletions

File tree

Basis/Packages/com.basis.framework/Networking/Handles/BasisNetworkHandleRemoval.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
using System;
22
using System.Collections.Concurrent;
33
using Basis.Scripts.Avatar;
4-
using Basis.Scripts.Device_Management;
54
using Basis.Scripts.Networking;
65
using Basis.Scripts.Networking.NetworkedAvatar;
76
using Basis.Scripts.Networking.Receivers;

Basis/Packages/com.basis.framework/Settings/SMModuleAvatarPerformanceLimits.cs

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ public static class SMModuleAvatarPerformanceLimits
2727
/// Performance Limits tab but short enough that the user sees the effect of a
2828
/// single change without obvious latency.
2929
/// </summary>
30-
private const float DebounceSeconds = 0.35f;
30+
private const double DebounceSeconds = 0.35f;
3131

3232
// Negative = nothing pending. Uses realtimeSinceStartup so the debounce
3333
// still fires when Time.timeScale is 0 (pause menu etc.).
34-
private static float _pendingFireTime = -1f;
34+
private static double _pendingFireTime = -1f;
3535

3636
[RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.BeforeSceneLoad)]
3737
private static void Register()
@@ -76,8 +76,16 @@ private static void OnTagFilterChanged()
7676
/// </summary>
7777
public static void SimulateDebounce()
7878
{
79-
if (_pendingFireTime < 0f) return;
80-
if (Time.realtimeSinceStartup < _pendingFireTime) return;
79+
if (_pendingFireTime < 0f)
80+
{
81+
return;
82+
}
83+
84+
if (Time.realtimeSinceStartupAsDouble < _pendingFireTime)
85+
{
86+
return;
87+
}
88+
8189
_pendingFireTime = -1f;
8290
ReconcileLoadedAvatars();
8391
}
@@ -103,7 +111,7 @@ private static void OnSettingChanged(string settingName, string value)
103111
/// </summary>
104112
private static void ScheduleReconcile()
105113
{
106-
_pendingFireTime = Time.realtimeSinceStartup + DebounceSeconds;
114+
_pendingFireTime = Time.realtimeSinceStartupAsDouble + DebounceSeconds;
107115
}
108116

109117
/// <summary>

0 commit comments

Comments
 (0)