testing some bug fixes

looking more into issues

people cant be trusted implemented a adjuster

Author: dooly123

Basis Server/BasisNetworkCore/Serializable/VoiceReceiversMessage.cs

@@ -41,8 +41,12 @@ public void Deserialize(NetDataReader reader, bool largeCount)
 
             if (count == 0)
             {
+                // Explicit "no recipients": use a non-null empty array so the consumer
+                // (BasisSavedState.AddLastData) treats this as a real clear. A null Users
+                // means "couldn't parse / corrupt" and is deliberately left for the consumer
+                // to ignore (keep the last-known recipients).
                 ReturnPool();
-                Users = null;
+                Users = Array.Empty<ushort>();
                 UsersLength = 0;
                 return;
             }
@@ -133,12 +137,14 @@ public void Serialize(NetDataWriter writer, bool largeCount)
         /// </summary>
         public void ReturnPool()
         {
-            if (Users != null)
+            // Only pool-rented arrays (length > 0) go back to the pool — never the
+            // Array.Empty<ushort>() "explicit empty" sentinel, and never null.
+            if (Users != null && Users.Length != 0)
             {
                 ArrayPool<ushort>.Shared.Return(Users);
-                Users = null;
-                UsersLength = 0;
             }
+            Users = null;
+            UsersLength = 0;
         }
 
         private static void SkipRemaining(NetDataReader reader)

Basis/Packages/com.basis.eventdriver/BasisEventDriver.cs

@@ -391,7 +391,7 @@ private void OnBeforeRender()
         /// <summary>
         /// Application quit hook. Disposes physics and stops microphone processing.
         /// </summary>
-        public async void OnApplicationQuit()
+        public void OnApplicationQuit()
         {
             JigglePhysics.Dispose();
 #if !BASIS_DISABLE_MICROPHONE

Basis/Packages/com.basis.framework.editor/Editor/BasisAvatarRecorderEditor.cs

@@ -553,9 +553,6 @@ private void LoadAndConvert()
 
     private void ConvertFileToAnimationClip(string path)
     {
-        if (BasisAvatarRecorder.BytesPerFrame <= 0)
-            return;
-
         if (!File.Exists(path))
         {
             EditorUtility.DisplayDialog("Convert to AnimationClip", $"File not found:\n{path}", "OK");

Basis/Packages/com.basis.framework.editor/Editor/BasisBeeExplorerWindow.cs

@@ -48,7 +48,7 @@ private void OnDestroy()
         }
     }
 
-    public async void OnGUI()
+    public void OnGUI()
     {
         scrollPosition = EditorGUILayout.BeginScrollView(scrollPosition);
 

Basis/Packages/com.basis.framework.editor/Editor/BasisHeadlessBuild.cs

@@ -58,7 +58,7 @@ private static void BuildServer(BuildTarget target)
         if (target == BuildTarget.StandaloneLinux64)
         {
             int linuxArchitecture = ParseLinuxArchitecture(linuxArchitectureArg);
-            PlayerSettings.SetArchitecture(targetGroup, linuxArchitecture);
+            PlayerSettings.SetArchitecture(NamedBuildTarget.FromBuildTargetGroup(targetGroup), linuxArchitecture);
             Debug.Log($"[BasisHeadlessBuild] Linux architecture(set)={linuxArchitecture}");
         }
         Debug.Log($"[BasisHeadlessBuild] activeBuildTarget(after)={EditorUserBuildSettings.activeBuildTarget}");

Basis/Packages/com.basis.framework/Avatar/BasisAvatarFactory.cs

@@ -608,11 +608,11 @@ private static async Task<SemaphoreSlim> ResolveGate(byte Mode, BasisLoadableBun
         }
 
         // Tracks the latest in-flight request per player (local/remote share this).
-        private static readonly ConcurrentDictionary<int, CancellationTokenSource> _playerLoadCts = new();
+        private static readonly ConcurrentDictionary<EntityId, CancellationTokenSource> _playerLoadCts = new();
 
         private static CancellationToken ReplacePlayerLoadToken(BasisPlayer player)
         {
-            int key = player.GetEntityId();
+            EntityId key = player.GetEntityId();
 
             // Cancel & dispose previous request (if any)
             if (_playerLoadCts.TryRemove(key, out var old))
@@ -628,7 +628,7 @@ private static CancellationToken ReplacePlayerLoadToken(BasisPlayer player)
 
         private static void ClearPlayerLoadToken(BasisPlayer player, CancellationToken token)
         {
-            int key = player.GetEntityId();
+            EntityId key = player.GetEntityId();
             if (_playerLoadCts.TryGetValue(key, out var cts) && cts.Token == token)
             {
                 _playerLoadCts.TryRemove(key, out _);
@@ -643,7 +643,7 @@ private static void ClearPlayerLoadToken(BasisPlayer player, CancellationToken t
         public static void CancelPlayerLoad(BasisPlayer player)
         {
             if (player == null) return;
-            int key = player.GetEntityId();
+            EntityId key = player.GetEntityId();
             if (_playerLoadCts.TryRemove(key, out var cts))
             {
                 try { cts.Cancel(); } catch { /* ignore */ }

Basis/Packages/com.basis.framework/Avatar/BasisAvatarModelCache.cs

@@ -9,7 +9,7 @@
 /// player switching back, or multiple remote players sharing the same model — skips
 /// the expensive bake/capture work and copies from cache instead.
 ///
-/// Cache key: <c>Animator.avatar.GetInstanceID()</c> — unique per loaded Avatar asset,
+/// Cache key: <c>Animator.avatar.GetEntityId()</c> — unique per loaded Avatar asset,
 /// stable across instances of the same model within a session.
 ///
 /// Subsystems store their data in typed slots on <see cref="Entry"/>. A null slot means
@@ -124,21 +124,21 @@ public class BonePresenceData
     //  Storage
     // ────────────────────────────────────────────────────────────
 
-    private static readonly Dictionary<int, Entry> _cache = new Dictionary<int, Entry>(16);
+    private static readonly Dictionary<EntityId, Entry> _cache = new Dictionary<EntityId, Entry>(16);
 
     /// <summary>
     /// Gets the cache key for an animator's avatar asset.
-    /// Returns 0 if the avatar is null (caller should skip caching).
+    /// Returns <see cref="EntityId.None"/> if the avatar is null (caller should skip caching).
     /// </summary>
-    public static int GetKey(Animator animator)
+    public static EntityId GetKey(Animator animator)
     {
-        return animator != null && animator.avatar != null ? animator.avatar.GetInstanceID() : 0;
+        return animator != null && animator.avatar != null ? animator.avatar.GetEntityId() : EntityId.None;
     }
 
     /// <summary>
     /// Gets or creates the cache entry for the given avatar asset key.
     /// </summary>
-    public static Entry GetOrCreate(int key)
+    public static Entry GetOrCreate(EntityId key)
     {
         if (!_cache.TryGetValue(key, out Entry entry))
         {
@@ -151,15 +151,15 @@ public static Entry GetOrCreate(int key)
     /// <summary>
     /// Tries to get an existing cache entry. Returns false if not cached.
     /// </summary>
-    public static bool TryGet(int key, out Entry entry)
+    public static bool TryGet(EntityId key, out Entry entry)
     {
         return _cache.TryGetValue(key, out entry);
     }
 
     /// <summary>
     /// Removes a specific avatar's cache entry (e.g., when its bundle is unloaded).
     /// </summary>
-    public static void Remove(int key)
+    public static void Remove(EntityId key)
     {
         _cache.Remove(key);
     }
@@ -190,10 +190,10 @@ public static void Clear()
     /// </summary>
     public static void RecordPosesCached(Basis.Scripts.Common.BasisTransformMapping mapping, Animator animator)
     {
-        int key = GetKey(animator);
+        EntityId key = GetKey(animator);
 
         // Cache hit: restore from arrays
-        if (key != 0 && TryGet(key, out var entry) && entry.TposeLocal != null && entry.TposeFromRoot != null && entry.TposeWorld != null)
+        if (key != EntityId.None && TryGet(key, out var entry) && entry.TposeLocal != null && entry.TposeFromRoot != null && entry.TposeWorld != null)
         {
             RestorePosesFromCache(mapping, animator, entry);
             return;
@@ -203,13 +203,13 @@ public static void RecordPosesCached(Basis.Scripts.Common.BasisTransformMapping
         mapping.RecordPoses(animator);
 
         // Store for next time
-        if (key != 0)
+        if (key != EntityId.None)
         {
             StorePosesToCache(key, mapping);
         }
     }
 
-    private static void StorePosesToCache(int key, Basis.Scripts.Common.BasisTransformMapping mapping)
+    private static void StorePosesToCache(EntityId key, Basis.Scripts.Common.BasisTransformMapping mapping)
     {
         var entry = GetOrCreate(key);
         int boneCount = (int)HumanBodyBones.LastBone;

Basis/Packages/com.basis.framework/Avatar/BasisAvatarTextureStats.cs

@@ -60,7 +60,7 @@ public static BasisAvatarTextureStats Collect(Renderer[] renderers, long downloa
             return stats;
 
         // Track unique textures by instance ID to avoid double-counting shared textures.
-        var seen = new HashSet<int>();
+        var seen = new HashSet<EntityId>();
 
         for (int r = 0; r < renderers.Length; r++)
         {
@@ -88,7 +88,7 @@ public static BasisAvatarTextureStats Collect(Renderer[] renderers, long downloa
                     Texture tex = mat.GetTexture(propName);
 
                     if (tex == null) continue;
-                    if (!seen.Add(tex.GetInstanceID())) continue;
+                    if (!seen.Add(tex.GetEntityId())) continue;
 
                     Texture2D tex2D = tex as Texture2D;
                     bool isStreaming = tex2D != null && tex2D.streamingMipmaps;

Basis/Packages/com.basis.framework/Camera/CopyColorToRTFeature.cs

@@ -112,12 +112,12 @@ public static void EnsureRT(in RenderingData renderingData, Settings settings)
             if (settings.forceHDR)
             {
                 var requested = GraphicsFormat.R16G16B16A16_SFloat;
-                desc.graphicsFormat = SystemInfo.GetCompatibleFormat(requested, FormatUsage.Render);
+                desc.graphicsFormat = SystemInfo.GetCompatibleFormat(requested, GraphicsFormatUsage.Render);
             }
             else
             {
                 // Keep camera's format, but ensure it's actually renderable on the platform.
-                desc.graphicsFormat = SystemInfo.GetCompatibleFormat(camDesc.graphicsFormat, FormatUsage.Render);
+                desc.graphicsFormat = SystemInfo.GetCompatibleFormat(camDesc.graphicsFormat, GraphicsFormatUsage.Render);
             }
 
             bool needsRebuild =

Basis/Packages/com.basis.framework/Device Management/Devices/Headless/BasisHeadlessManagement.cs

@@ -77,7 +77,7 @@ private void OnSceneLoadeded(Scene arg0, Scene arg1)
     /// </summary>
     private void RemoveAllMaterialTextures()
     {
-        Renderer[] renderers = FindObjectsByType<Renderer>(FindObjectsInactive.Include, FindObjectsSortMode.None);
+        Renderer[] renderers = FindObjectsByType<Renderer>(FindObjectsInactive.Include);
         HashSet<Material> processedMats = new HashSet<Material>();
 
         foreach (Renderer renderer in renderers)
@@ -181,7 +181,7 @@ public static void ClearAllKnownTextures(Material material)
     /// </summary>
     private void RemoveAllReflectionProbes()
     {
-        ReflectionProbe[] probes = FindObjectsByType<ReflectionProbe>(FindObjectsInactive.Include, FindObjectsSortMode.None);
+        ReflectionProbe[] probes = FindObjectsByType<ReflectionProbe>(FindObjectsInactive.Include);
         foreach (ReflectionProbe probe in probes)
         {
             Destroy(probe.gameObject);
@@ -214,7 +214,7 @@ private void RemoveSceneCubemapReferences()
 
     private void RemoveAllLightmapReferences()
     {
-        Renderer[] renderers = FindObjectsByType<Renderer>(FindObjectsInactive.Include, FindObjectsSortMode.None);
+        Renderer[] renderers = FindObjectsByType<Renderer>(FindObjectsInactive.Include);
         foreach (Renderer renderer in renderers)
         {
             if (renderer == null)
@@ -244,7 +244,7 @@ private void RemoveAllLightmapReferences()
     /// </summary>
     private void RemoveAllText()
     {
-        Canvas[] canvases = FindObjectsByType<Canvas>(FindObjectsInactive.Include, FindObjectsSortMode.None);
+        Canvas[] canvases = FindObjectsByType<Canvas>(FindObjectsInactive.Include);
         foreach (Canvas canvas in canvases)
         {
             Destroy(canvas);