Skip to content

Commit 8f42393

Browse files
dooly123claude
andcommitted
Remove the baked-in announcement (rely on the live feed)
The app no longer ships a built-in announcement — announcements come only from the live basisvr.org/announcements.json feed. The embedded fallback is now empty, so offline the app shows nothing rather than a stale baked-in notice. Seen-tracking is unchanged: SeenAnnouncementIds still records read announcements so they don't re-badge as unread. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 99e33cc commit 8f42393

2 files changed

Lines changed: 6 additions & 17 deletions

File tree

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1 @@
1-
[
2-
{
3-
"id": "2026-07-04-early-preview",
4-
"level": "info",
5-
"pinned": true,
6-
"date": "2026-07-04",
7-
"title": "This is a preview — and still very early",
8-
"body": "Thanks for trying the Basis Package Manager! It's an early preview and very much a work in progress, so expect rough edges, missing features, and the occasional breaking change. Your feedback genuinely shapes where it goes next.",
9-
"url": "https://discord.gg/v6ve6WT562",
10-
"linkText": "Share feedback on Discord"
11-
}
12-
]
1+
[]

tests/BasisPM.Core.Tests/AnnouncementServiceTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,10 @@ namespace BasisPM.Core.Tests;
77
public sealed class AnnouncementServiceTests
88
{
99
[Fact]
10-
public void LoadEmbedded_returns_the_baked_in_feed()
10+
public void LoadEmbedded_returns_an_empty_feed()
1111
{
12-
var items = AnnouncementService.LoadEmbedded();
13-
Assert.NotEmpty(items);
14-
Assert.Contains(items, a => a.Id == "2026-07-04-early-preview" && a.Pinned);
12+
// No announcements are baked into the app — they come only from the live feed.
13+
Assert.Empty(AnnouncementService.LoadEmbedded());
1514
}
1615

1716
[Fact]
@@ -66,8 +65,9 @@ public async Task LoadAsync_sorts_undated_items_last()
6665
[Fact]
6766
public async Task LoadAsync_falls_back_to_embedded_when_offline()
6867
{
68+
// Offline falls back to the embedded feed, which is now empty (no baked-in announcements).
6969
var svc = new AnnouncementService(StubHttpMessageHandler.AlwaysThrows());
7070
var items = await svc.LoadAsync("https://example.com/announcements.json");
71-
Assert.Contains(items, a => a.Id == "2026-07-04-early-preview");
71+
Assert.Empty(items);
7272
}
7373
}

0 commit comments

Comments
 (0)