Skip to content

Commit 91e21e7

Browse files
committed
remove psalm & fix phpcs
1 parent fe304e4 commit 91e21e7

8 files changed

Lines changed: 160 additions & 2765 deletions

File tree

.github/workflows/quality.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ jobs:
88
strategy:
99
matrix:
1010
operating-system: [ ubuntu-latest ]
11-
php-versions: [ '7.4' ]
11+
php-versions: [ '8.0' ]
1212
name: PHP ${{ matrix.php-versions }} Test on ${{ matrix.operating-system }}
1313
steps:
1414
- name: Checkout

classes/Controllers/Controller.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,12 @@ public static function get_current_controller() {
102102
* @return bool
103103
* @author Nicolas Juen
104104
*/
105-
public static function filter_classes( string $class ): bool {
106-
if ( false === is_subclass_of( $class, '\BEA\PB\Controller', true ) ) {
105+
public static function filter_classes( string $class_name ): bool {
106+
if ( false === is_subclass_of( $class_name, '\BEA\PB\Controller', true ) ) {
107107
return false;
108108
}
109109

110-
return $class::get_instance()->is_page();
110+
return $class_name::get_instance()->is_page();
111111
}
112112

113113
/**

classes/Cron/Cron.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace BEA\PB;
44

5-
use \Bea_Log;
5+
use \Bea_Log; //phpcs:ignore Universal.UseStatements.NoLeadingBackslash.LeadingBackslashFound
66

77
/**
88
* This class needs Bea_Log to work

composer.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,11 @@
2828
"phpcompatibility/php-compatibility": "9.3.5",
2929
"phpro/grumphp-shim": "v2.18.0",
3030
"squizlabs/php_codesniffer": "3.13.5",
31-
"vimeo/psalm": "6.14.2",
3231
"wp-coding-standards/wpcs": "3.3.0"
3332
},
3433
"scripts": {
3534
"cs": "./vendor/bin/phpcs",
36-
"cb": "./vendor/bin/phpcbf",
37-
"psalm": "./vendor/bin/psalm"
35+
"cb": "./vendor/bin/phpcbf"
3836
},
3937
"suggest": {
4038
"wp-cli/wp-cli": "*@stable"

0 commit comments

Comments
 (0)