Merge pull request #47 from BeAPI/fix/model-get-terms

petitphp · web-flow · commit e52013b6551c · 2024-08-06T12:05:05.000+02:00
Use `get_the_terms` when possible to retrieve post's terms
diff --git a/classes/Models/Model.php b/classes/Models/Model.php
@@ -214,12 +214,11 @@ public function set_terms( $terms, string $taxonomy, $append = false ) {
 	 * @return \WP_Term[]|\WP_Error
 	 */
 	public function get_terms( string $taxonomy, array $args = [] ) {
-		$terms = get_object_term_cache( $this->get_id(), $taxonomy );
-		if ( false === $terms ) {
-			$terms = wp_get_object_terms( $this->get_id(), $taxonomy, $args );
+		if ( empty( $args ) ) {
+			return get_the_terms( $this->get_id(), $taxonomy );
 		}
 
-		return $terms;
+		return wp_get_object_terms( $this->get_id(), $taxonomy, $args );
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -214,12 +214,11 @@ public function set_terms( $terms, string $taxonomy, $append = false ) {`
`214`	`214`	`* @return \WP_Term[]\|\WP_Error`
`215`	`215`	`*/`
`216`	`216`	`public function get_terms( string $taxonomy, array $args = [] ) {`
`217`		`- $terms = get_object_term_cache( $this->get_id(), $taxonomy );`
`218`		`- if ( false === $terms ) {`
`219`		`- $terms = wp_get_object_terms( $this->get_id(), $taxonomy, $args );`
	`217`	`+ if ( empty( $args ) ) {`
	`218`	`+ return get_the_terms( $this->get_id(), $taxonomy );`
`220`	`219`	`}`
`221`	`220`
`222`		`- return $terms;`
	`221`	`+ return wp_get_object_terms( $this->get_id(), $taxonomy, $args );`
`223`	`222`	`}`
`224`	`223`
`225`	`224`	`/**`