Refactor filename sanitization logic and expand unit tests#29
Merged
herewithme merged 1 commit intomasterfrom Apr 7, 2026
Merged
Refactor filename sanitization logic and expand unit tests#29herewithme merged 1 commit intomasterfrom
herewithme merged 1 commit intomasterfrom
Conversation
- Updated the `bea_sanitize_file_name` function to improve extension handling, ensuring only the suffix is removed. - Enhanced unit tests to cover various filename scenarios, including accented characters, underscores to dashes conversion, and upload-style filenames. - Added data providers for better test organization and clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bea_sanitize_file_namefunction to improve extension handling, ensuring only the suffix is removed.Note
Medium Risk
Changes the filename sanitization output for multi-dot filenames by stripping the extension only when it appears as the final suffix, which could affect stored upload filenames/URLs. Risk is mitigated by significantly expanded unit test coverage across common and edge-case filenames.
Overview
Filename sanitization logic is tightened so the plugin derives the extension via
pathinfo()and removes it only as a true end-of-string suffix (avoiding accidental removal of matching substrings in multi-dot names), then reattaches it unchanged.Unit tests are massively expanded and reorganized using data providers to cover accents/transliteration interactions, underscore/space handling, special character stripping (including
@,€,©), UTF-8/non‑Latin names, and multi-dot “fake extension” cases from WordPress core.Reviewed by Cursor Bugbot for commit d6a38c0. Bugbot is set up for automated code reviews on this repo. Configure here.