Fix default links and external link icon position

cedric07 · cedric07 · commit 468e8f86588f · 2026-04-03T15:10:25.000+02:00
diff --git a/src/img/static/external.svg b/src/img/static/external.svg
@@ -0,0 +1,3 @@
+<svg width="20" height="20" viewBox="0 0 20 20" xmlns="http://www.w3.org/2000/svg">
+    <path d="M4.5 17C4.0875 17 3.73437 16.8531 3.44062 16.5594C3.14687 16.2656 3 15.9125 3 15.5V4.5C3 4.0875 3.14687 3.73438 3.44062 3.44063C3.73437 3.14688 4.0875 3 4.5 3H10V4.5H4.5V15.5H15.5V10H17V15.5C17 15.9125 16.8531 16.2656 16.5594 16.5594C16.2656 16.8531 15.9125 17 15.5 17H4.5ZM8.0625 13L7 11.9375L14.4375 4.5H12V3H17V8H15.5V5.5625L8.0625 13Z"/>
+</svg>
diff --git a/src/scss/02-tools/_f-get-svg-url.scss b/src/scss/02-tools/_f-get-svg-url.scss
@@ -40,7 +40,6 @@
 		// name-of-the-svg: (viewBox, content of the svg element)
 		"arrow": ("0 0 18 14", "%3Cpath d='M17.25 7 10.37.12l-.96.97 5.2 5.22H.76V7.7h13.87L9.4 12.9l.96.96L17.25 7Z'/%3E"),
 		"down": ("0 0 11.2 6.7", "3Cpath d='M0 .5C0 .4.1.2.2.1c.2-.2.5-.1.7.1l4.6 5.3.1.1s.1 0 .1-.1L10.3.1c.2-.1.5-.2.7 0 .2.2.2.5.1.7L6.5 6.2c-.2.3-.5.5-.9.5s-.7-.2-.9-.6L.1.8C0 .7 0 .6 0 .5z'/%3E"),
-		"external": ("0 0 20 20", "3Cpath d='M3.1 19.6A3.1 3.1 0 0 1 0 16.4V3.1A3.2 3.2 0 0 1 3.1 0H4c.4 0 .7.3.7.7 0 .4-.3.8-.7.8H3c-.9 0-1.6.7-1.6 1.6v13.3c0 1 .7 1.7 1.6 1.7h13.2c.9 0 1.6-.8 1.6-1.7v-.8c0-.4.4-.7.8-.7s.7.3.7.7v.8c0 1.7-1.4 3.2-3.1 3.2H3ZM18.7 0c.4 0 .7.3.7.7v10c0 .4-.4.7-.8.7s-.7-.3-.7-.8V2.5l-9.7 9.8c-.3.2-.8.3-1 0a.7.7 0 0 1 0-1l9.7-9.8H8.8c-.5 0-.8-.3-.8-.7 0-.4.3-.8.8-.8h9.9Z'/%3E"),
 		"close": ("0 0 20 20", "3Cpath d='M5.442 5.442 5 5.883l2.058 2.059L9.116 10l-2.058 2.058L5 14.117l.442.441.441.442 2.059-2.058L10 10.884l2.058 2.058L14.117 15l.441-.442.442-.441-2.058-2.059L10.884 10l2.058-2.058L15 5.883l-.442-.441L14.117 5l-2.059 2.058L10 9.116 7.942 7.058 5.883 5l-.441.442'/%3E"),
 	);
 
diff --git a/src/scss/02-tools/_m-text-icon.scss b/src/scss/02-tools/_m-text-icon.scss
@@ -17,18 +17,18 @@
  */
 
 @mixin text-icon($icon: "arrow", $position: after, $color: currentColor, $size: 12px, $gap: 8px) {
-	position: relative;
 	display: inline-flex;
 	gap: $gap;
 	align-items: center;
 
 	&::#{$position} {
 		display: block;
 		width: $size;
+		min-width: $size;
 		height: $size;
 		content: "";
 		background-color: $color;
-		mask-image: get-svg-url($icon);
+		mask-image: url(../img/static/#{$icon}.svg);
 		mask-position: center;
 		mask-repeat: no-repeat;
 		transition: background-color .5s $ease-out-expo;
@@ -38,9 +38,11 @@
 @mixin text-external-icon($icon: "external", $position: after, $color: currentColor, $size: 12px, $gap: 8px) {
 	@include text-icon($icon, $position, $color, $size);
 	display: inline-block;
+	gap: 0;
 
 	&::#{$position} {
 		display: inline-block;
 		margin-inline-start: $gap;
+		vertical-align: middle;
 	}
 }
diff --git a/src/scss/03-base/_links.scss b/src/scss/03-base/_links.scss
@@ -7,14 +7,22 @@ a {
 	cursor: pointer;
 
 	&[target="_blank"] {
-		@include text-icon("external");
+		@include text-external-icon("external");
 	}
 
 	@include hover {
 		text-decoration: none;
 	}
 }
 
+a,
+button {
+	text-decoration-thickness: 1px !important;
+	text-underline-position: from-font;
+	text-decoration-skip-ink: none;
+	cursor: pointer;
+}
+
 .link-external {
-	@include text-icon("external");
+	@include text-external-icon("external");
 }

Original file line number	Diff line number	Diff line change
`@@ -7,14 +7,22 @@ a {`
`7`	`7`	`cursor: pointer;`
`8`	`8`
`9`	`9`	`&[target="_blank"] {`
`10`		`- @include text-icon("external");`
	`10`	`+ @include text-external-icon("external");`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`@include hover {`
`14`	`14`	`text-decoration: none;`
`15`	`15`	`}`
`16`	`16`	`}`
`17`	`17`
	`18`	`+a,`
	`19`	`+button {`
	`20`	`+ text-decoration-thickness: 1px !important;`
	`21`	`+ text-underline-position: from-font;`
	`22`	`+ text-decoration-skip-ink: none;`
	`23`	`+ cursor: pointer;`
	`24`	`+}`
	`25`	`+`
`18`	`26`	`.link-external {`
`19`		`- @include text-icon("external");`
	`27`	`+ @include text-external-icon("external");`
`20`	`28`	`}`