Skip to content

Commit d25ef94

Browse files
committed
refactor: enhance semantic HTML by adding ARIA roles to header, footer, and main elements
1 parent 5f2bb00 commit d25ef94

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

footer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
</main>
2-
<footer id="footer" tabindex="-1" class="footer" aria-label="<?php esc_attr_e( 'Footer', 'beapi-frontend-framework' ); ?>">
1+
</main>
2+
<footer role="contentinfo" id="footer" tabindex="-1" class="footer" aria-label="<?php esc_attr_e( 'Footer', 'beapi-frontend-framework' ); ?>">
33

44
</footer>
55
<?php wp_footer(); ?>

header.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
</li>
4242
</ul>
4343
</nav>
44-
<header id="header" class="header" aria-label="<?php esc_attr_e( 'Header', 'beapi-frontend-framework' ); ?>">
44+
<header role="banner" id="header" class="header" aria-label="<?php esc_attr_e( 'Header', 'beapi-frontend-framework' ); ?>">
4545
<div class="header__inner">
4646
<div class="container">
4747
<a class="header__logo-link" href="<?php echo esc_url( home_url( '/' ) ); ?>">
@@ -55,7 +55,7 @@
5555
<span class="sr-only aria-expanded-true-text"><?php esc_html_e( 'Close the menu', 'beapi-frontend-framework' ); ?></span>
5656
</button>
5757

58-
<nav id="menu" tabindex="-1" class="header__menu" aria-label="<?php esc_attr_e( 'Main navigation', 'beapi-frontend-framework' ); ?>">
58+
<nav role="navigation" id="menu" tabindex="-1" class="header__menu" aria-label="<?php esc_attr_e( 'Main navigation', 'beapi-frontend-framework' ); ?>">
5959
<div>
6060
<?php
6161
wp_nav_menu(
@@ -74,7 +74,7 @@
7474
</div>
7575
</div>
7676
</header>
77-
<main id="content" tabindex="-1" aria-label="<?php esc_attr_e( 'Main content', 'beapi-frontend-framework' ); ?>">
77+
<main role="main" id="content" tabindex="-1" aria-label="<?php esc_attr_e( 'Main content', 'beapi-frontend-framework' ); ?>">
7878
<?php
7979
if ( ! is_front_page() && ! is_search() && ! is_404() ) {
8080
get_template_part( 'components/parts/common/breadcrumb' );

0 commit comments

Comments
 (0)