Fix TpvScene3D.TLight.BeforeDestruction#53
Open
michaliskambi wants to merge 1 commit intoBeRo1985:masterfrom
Open
Fix TpvScene3D.TLight.BeforeDestruction#53michaliskambi wants to merge 1 commit intoBeRo1985:masterfrom
michaliskambi wants to merge 1 commit intoBeRo1985:masterfrom
Conversation
…stance.fManualLights with index -1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code in
TpvScene3D.TLight.BeforeDestructionwas accidentally doingwhen
fIndexis obviously -1 (set to -1 byfinallyclause a few lines higher).This was causing range check errors when destroying certain animals in our game:)
It seems that it's a copy-paste error, the code under
if fManualIndex>=0 then beginseems mostly a copy-paste of the code underif fIndex>=0 then begin, you possibly copied it and didn't adjust all occurences offIndex->fManualIndex?Tested the solution on our game, and destroying some animals crashes no more:)