Fix all compiler warnings

Author: bcardarella

lib/beacon/content.ex

@@ -4395,7 +4395,6 @@ defmodule Beacon.Content do
     case insert_published_page(page) do
       {:ok, page} ->
         :ok = Beacon.PubSub.page_published(page)
-        # Async: extract internal links from the published page
         maybe_rebuild_links_async(page)
         {:reply, {:ok, page}, config}
 
@@ -4404,26 +4403,6 @@ defmodule Beacon.Content do
     end
   end
 
-  defp maybe_rebuild_links_async(page) do
-    Task.start(fn ->
-      try do
-        template = Beacon.Lifecycle.Template.load_template(page)
-        ast = Beacon.Template.Parser.parse(template)
-        component_registry = build_component_registry_for_ast(page.site)
-        expanded = Beacon.Template.ComponentExpander.expand(ast, component_registry)
-        # Render with empty assigns — works for static pages.
-        # Pages with data bindings will fail here, which is expected.
-        # Their links are extracted when the client reports them (future feature).
-        html = Beacon.Client.LiveViewCompiler.render_to_string(expanded, %{})
-        rebuild_links_for_page(page.site, page.id, html)
-      rescue
-        _error -> :ok
-      catch
-        _kind, _reason -> :ok
-      end
-    end)
-  end
-
   @doc false
   def handle_call({:unpublish_page, page}, _from, config) do
     case insert_unpublished_page(page) do
@@ -4879,6 +4858,23 @@ defmodule Beacon.Content do
     {:noreply, config}
   end
 
+  defp maybe_rebuild_links_async(page) do
+    Task.start(fn ->
+      try do
+        template = Beacon.Lifecycle.Template.load_template(page)
+        ast = Beacon.Template.Parser.parse(template)
+        component_registry = build_component_registry_for_ast(page.site)
+        expanded = Beacon.Template.ComponentExpander.expand(ast, component_registry)
+        html = Beacon.Client.LiveViewCompiler.render_to_string(expanded, %{})
+        rebuild_links_for_page(page.site, page.id, html)
+      rescue
+        _error -> :ok
+      catch
+        _kind, _reason -> :ok
+      end
+    end)
+  end
+
   # ---------------------------------------------------------------------------
   # Template Types
   # ---------------------------------------------------------------------------
@@ -4909,7 +4905,7 @@ defmodule Beacon.Content do
   @doc "Lists template types available to a site (includes global types where site is nil)."
   @doc type: :template_types
   @spec list_template_types(Site.t(), keyword()) :: [TemplateType.t()]
-  def list_template_types(site, opts \\ []) when is_atom(site) do
+  def list_template_types(site, _opts \\ []) when is_atom(site) do
     from(tt in TemplateType,
       where: tt.site == ^site or is_nil(tt.site),
       order_by: [asc: tt.name]

lib/beacon/content/content_diff.ex

@@ -67,8 +67,8 @@ defmodule Beacon.Content.ContentDiff do
 
   # Computes the percentage of tokens that differ using set-based comparison.
   defp token_change_percentage([], []), do: 0.0
-  defp token_change_percentage(current, []), do: 1.0
-  defp token_change_percentage([], previous), do: 1.0
+  defp token_change_percentage(_current, []), do: 1.0
+  defp token_change_percentage([], _previous), do: 1.0
 
   defp token_change_percentage(current, previous) do
     current_set = MapSet.new(current)

lib/beacon/seo/index_now.ex

@@ -153,8 +153,8 @@ defmodule Beacon.SEO.IndexNow do
   end
 
   defp http_post(url, body) do
-    headers = [{'content-type', 'application/json; charset=utf-8'}]
-    :httpc.request(:post, {String.to_charlist(url), headers, 'application/json', String.to_charlist(body)}, [timeout: 10_000], [])
+    headers = [{~c"content-type", ~c"application/json; charset=utf-8"}]
+    :httpc.request(:post, {String.to_charlist(url), headers, ~c"application/json", String.to_charlist(body)}, [timeout: 10_000], [])
     |> handle_httpc_response()
   end
 

lib/beacon/seo/json_ld.ex

@@ -208,10 +208,6 @@ defmodule Beacon.SEO.JsonLd do
     end)
   end
 
-  defp format_datetime(%DateTime{} = dt), do: DateTime.to_iso8601(dt)
-  defp format_datetime(%NaiveDateTime{} = ndt), do: NaiveDateTime.to_iso8601(ndt)
-  defp format_datetime(str) when is_binary(str), do: str
-  defp format_datetime(_), do: nil
 
   defp put_if(map, _key, nil), do: map
   defp put_if(map, _key, ""), do: map