Skip to content

Commit db04cbb

Browse files
committed
fix: resolve test failure and deprecation warnings
- Add sync point in router_server_test after send to handle_info, since lookup_path now reads ETS directly and needs the GenServer to have processed the message first - Replace deprecated Igniter.Project.Config.modify_configuration_code with modify_config_code
1 parent cea9f55 commit db04cbb

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

lib/mix/tasks/beacon.gen.site.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,7 @@ if Code.ensure_loaded?(Igniter) do
505505
{:ok,
506506
zipper
507507
|> Beacon.Igniter.move_to_variable!(:signing_salt)
508-
|> Igniter.Project.Config.modify_configuration_code(
508+
|> Igniter.Project.Config.modify_config_code(
509509
[site_endpoint],
510510
otp_app,
511511
Sourceror.parse_string!("""
@@ -556,7 +556,7 @@ if Code.ensure_loaded?(Igniter) do
556556
{:ok,
557557
zipper
558558
|> Beacon.Igniter.move_to_variable!(:secret_key_base)
559-
|> Igniter.Project.Config.modify_configuration_code(
559+
|> Igniter.Project.Config.modify_config_code(
560560
[site_endpoint],
561561
otp_app,
562562
Sourceror.parse_string!(config)

test/beacon/router_server_test.exs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@ defmodule Beacon.RouterServerTest do
9696

9797
server = site |> Beacon.RouterServer.name() |> GenServer.whereis()
9898
send(server, {:page_loaded, page})
99+
# Ensure the handle_info has been processed before reading ETS directly
100+
RouterServer.dump_pages(site)
99101

100102
assert %Beacon.Content.Page{id: ^page_id} = Beacon.RouterServer.lookup_page!(site, ["test", "router", "add"])
101103
end

0 commit comments

Comments
 (0)