fix: add unique constraint on component name per site#861
Open
mvanhorn wants to merge 1 commit intoBeaconCMS:mainfrom
Open
fix: add unique constraint on component name per site#861mvanhorn wants to merge 1 commit intoBeaconCMS:mainfrom
mvanhorn wants to merge 1 commit intoBeaconCMS:mainfrom
Conversation
Adds a unique_constraint on [:site, :name] to the Component changeset and creates migration V007 with the corresponding database index. This prevents duplicate component names within a site which would cause compilation issues since function overloading is not supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a unique constraint on
[:site, :name]for components to prevent duplicate component names within a site. Duplicate names cause compilation issues since function overloading is not supported.Changes
lib/beacon/content/component.ex: Addedunique_constraint([:site, :name])to the changeset pipelinelib/beacon/migrations/v007.ex: New migration creating the unique index onbeacon_componentstablelib/beacon/migration.ex: Bumped@current_versionfrom 6 to 7Follows the same pattern as existing unique constraints on pages (
:path, :site) and error pages (:status, :site).Fixes #650
This contribution was developed with AI assistance (Claude Code).