Skills pages#87
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
DecampsRenan
force-pushed
the
feat/skills
branch
from
a67880a to
32db3fc
Compare
DecampsRenan
force-pushed
the
feat/skills
branch
from
f74033c to
d8e2206
Compare
DecampsRenan
force-pushed
the
feat/skills
branch
from
d8e2206 to
60618b1
Compare
| { | ||
| !!linkedPosts.length && ( | ||
| <Container> | ||
| <div class="flex flex-col gap-4"> | ||
| <h2 class="font-heading text-2xl font-bold"> | ||
| {t('skills.detail.blog.title', { name: skill.data.name })} | ||
| </h2> | ||
| <PostsCarousel | ||
| client:load | ||
| posts={linkedPosts.slice(0, POSTS_LIMIT)} | ||
| locale={locale} | ||
| /> | ||
| </div> | ||
| </Container> | ||
| ) | ||
| } |
There was a problem hiding this comment.
this part is missing the "See more" if there is more articles than the LIMIT; but for this to work I need to create the correct page filter in the posts (maybe it can be done in another PR)
DecampsRenan
force-pushed
the
feat/skills
branch
from
2c97665 to
a3de1c2
Compare
DecampsRenan
force-pushed
the
feat/skills
branch
from
a3de1c2 to
e2a2f25
Compare
yoannfleurydev
force-pushed
the
feat/skills
branch
from
e2a2f25 to
30aae32
Compare
Remove the image on mobile |
| } | ||
| <div class="flex items-center gap-4"> | ||
| { | ||
| !!title && ( |
There was a problem hiding this comment.
If there is no title, we have an empty div, is that what we want?
There was a problem hiding this comment.
Good catch, we don't want that :D
| </h1> | ||
| ) | ||
| } | ||
| <div class="flex items-center gap-4"> |
There was a problem hiding this comment.
The added <div class="flex items-center gap-4"> wrapper around the <h1> doesn't appear to serve a purpose here — it wraps a single element. It looks like it was added to support the skill detail page layout (icon + title), but that page uses <slot> with its own custom markup rather than the title prop. This wrapper adds an unnecessary DOM node for all other hero usages.
| skills: | ||
| - 'ux' | ||
| - 'wireframes' | ||
| - 'prototypage' |
There was a problem hiding this comment.
Bug: 'prototypage' does not match any existing skill directory. The skill is named prototype (see src/content/skills/prototype/). This post won't appear in linked posts for the prototype skill, and it may cause a build error with reference('skills') validation.
| - 'prototypage' | |
| - 'prototype' |
2 participants
closes #67
Add skills detail pages.
What is the goal of this PR:
To add later:
CleanShot.2026-04-03.at.12.11.00.mp4