Skip to content

Android client. Fixed the bug that sounds were not properly muted in outgoing calls like incoming calls#3304

Open
amirmahdifard wants to merge 4 commits into
BearWare:masterfrom
amirmahdifard:phonecallfix
Open

Android client. Fixed the bug that sounds were not properly muted in outgoing calls like incoming calls#3304
amirmahdifard wants to merge 4 commits into
BearWare:masterfrom
amirmahdifard:phonecallfix

Conversation

@amirmahdifard
Copy link
Copy Markdown
Contributor

in teamtalk android, we were handling incoming calls grately so there was no problem with them, but outgoing calls when you were in teamtalk was very annoying. If you had an outgoing call and you were in teamtalk and someone logged out and logged back in and opened their microphone, their microphone would play on your call. Incoming calls didn't have this bug. This was because we were not handling the offhook case for the calls. it has now been fixed

@hwangsihu
Copy link
Copy Markdown
Contributor

Hmm, I can't merge it. What's the problem?

@amirmahdifard
Copy link
Copy Markdown
Contributor Author

idk. One of my problems here is that I have to wait long for my pull requests to be merged which I don't like. Because I like to move my developments progress forward fast.

@amirmahdifard
Copy link
Copy Markdown
Contributor Author

I have to wait 2 years for a pull request that only changes 3 or 4 lines of code to be merged. Interesting.

@Nardol
Copy link
Copy Markdown
Contributor

Nardol commented Jun 5, 2026

@amirmahdifard We wish to wait more than two hours between two complains from you but this is not the case. Unfortunately we don't have everything we wish!

@amirmahdifard
Copy link
Copy Markdown
Contributor Author

@Nardol it's not only my case. Everyone have problems. Sadly you don't understand my sichuation too, so please at least stay out of the conversation. People are strange. if we work, they do like this. If there are no update, they say why they are not working on it.

@Nardol
Copy link
Copy Markdown
Contributor

Nardol commented Jun 6, 2026

@amirmahdifard You are spamming subscribers' inbox with your complains and I should shut up?
I perfectly understand your situation, particularly how it is frustrating when we feel a contribution we make has no reply fast enough.
Harassing people is not a solution. Write directly to @bear101 if you have something to tell him.

@amirmahdifard
Copy link
Copy Markdown
Contributor Author

@Nardol bro i'm not a child I know I must tell him, but what should I do when hes ignoaring me all the time? i'm saying this since you say you understand. What would you feel when you find a working vpn, connect to it, set up your development envirenment, code, test, wait for compilation with slow network, clone with slow network pulling and pushing takes 12 hours, submit pull request, and @bear101 is ignoaring me. He even doesn't see my pull requests properly, I never submit not working pull requests. He and anyone can pull and compile my pull requests and see my changes. Idk what should I do onistly. If he starts answering me finally then i'll continue my work, but work is impossible when the owner of the project is ignoaring vollentary contributors.

@CoBC
Copy link
Copy Markdown
Contributor

CoBC commented Jun 7, 2026

We all have lives outside of TeamTalk, GitHub, and development. The project maintainers are not available to you. You cannot demand that your PRs be merged in just a few hours, and stop complaining that your PRs remained open for 2 or 3 years, that's completely false, you never appeared on this project 2 or 3 years ago.
Stop spamming comments and mentioning everyone 5 times in a row, we've already asked you this too many times

Re-indent the bodies of the new inPhoneCall guard blocks so they match
their enclosing braces. No behavioural change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants