Android client. Fixed and recoded files system#3310
Conversation
amirmahdifard
commented
Jun 1, 2026
amirmahdifard
commented
- Redesighned files tab, popup menus and clicks on files, and confirmation for canceling downloads
- We had a notification to show the uploading file's progress but it was broken, Fixed it.
amirmahdifard
requested review from
a team,
bear101,
beqabeqa473,
hwangsihu and
poretsky
as code owners
|
@bear101 this pr is ready, the commit history is clean, and everything is ok. Please merge. Thanks |
|
@bear101 hi. Sorry to take your time, but I want to request you to please merge my pull requests faster because here in iran, nothing has garantee. No garantee if my internet will be disconnected next week, no garantee if my vpn server will be filtered tonight, so I want to be active as much as my internet and my vpn is connected. Thanks alot for your understanding! |
|
@bear101 I don't understand why you make this pull request draft. Is it ready for merge And I marked it as ready for review. You don't want to merge my pull requests? |
|
@bear101 onnistly I don't know why you are behaving like this. I opened all these pull requests in just 2 days with all dificaltys of my cuntry iran, with internet problems, vpn problems, slo network problem, a temporary vpn that expires after 3 days and I have to find another one, I open these pull requests, and you are not pressing the merge button. I suggest you come and live in iran for 1 week. Then you'll understand what does this dificalty means |
|
@hwangsihu do you know why he changed my pr to draft? this pr is ready. if you have android device you can just compile this and you're good to go! I think now you understand the reason why working in this project is so hard. If you can compile this, compile and test it yourself, May be you can merge my pull requests |
|
@hwangsihu @bear101 You should know this but the lint was faling due to I removed this useless string |
Drop imports left unused by the files-tab popup-menu rework: ClientFlag, ClientStatistics, ClientEvent, User and PopupMenu.OnMenuItemClickListener were added but never referenced, and Notification, Button and DialogInterface became unused once the inline buttons were replaced by row click/long-press handlers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@hwangsihu thanks. The button download is also unused now in strings.xml but when i'm removing it, github actions complanes and says this string also exist on other translations strings.xml. So you must remove it from all translations strings.xml |
2 participants
