Android client. Messages history fixes and redesighns#3311
Open
amirmahdifard wants to merge 3 commits into
Open
Android client. Messages history fixes and redesighns#3311amirmahdifard wants to merge 3 commits into
amirmahdifard wants to merge 3 commits into
Conversation
Contributor
amirmahdifard
commented
Jun 2, 2026
amirmahdifard
commented
- Added popup menu actions for messages.
- Replaced the old broken buggy single link support system with a new proper multiple links support system, Just like the desktop qt teamtalk's multiple links support for messages!
amirmahdifard
requested review from
a team,
bear101,
beqabeqa473,
hwangsihu and
poretsky
as code owners
bear101
requested changes
Jun 5, 2026
hwangsihu
previously approved these changes
Jun 7, 2026
- Replace magic number 1000 with named constant URL_MENU_ITEM_BASE (addresses review feedback) - Remove unused PopupMenu.OnMenuItemClickListener import - Prepend http:// scheme to scheme-less links so ACTION_VIEW resolves them, and guard startActivity against ActivityNotFoundException Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
@hwangsihu thanks for this, I could also do this, but I mean, what's the problem with that 1000 thingy, for avoid it, we had to creat a extra more helper, which now you did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.