Android client. Added the forgotan Subscription and transmission changes to the chat list#3312
Open
amirmahdifard wants to merge 4 commits into
Open
Android client. Added the forgotan Subscription and transmission changes to the chat list#3312amirmahdifard wants to merge 4 commits into
amirmahdifard wants to merge 4 commits into
Conversation
amirmahdifard
requested review from
a team,
bear101,
beqabeqa473,
hwangsihu and
poretsky
as code owners
bear101
requested changes
Jun 5, 2026
Contributor
bear101
left a comment
bear101
left a comment
There was a problem hiding this comment.
These changes will overflow the chat history. I suggest they should be disabled by default.
hwangsihu
previously approved these changes
Jun 7, 2026
onCmdChannelUpdate() logged transmission changes for every channel update, so changes in channels the user is not in would appear in the chat history. Restrict it to mychannel, matching the existing text-to-speech behaviour in MainActivity.onCmdChannelUpdate(), and fix the stray indentation/spacing in the touched blocks. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
@hwangsihu I didn't see this statement in main activity I think that's why I forgot to add it at the first place. Thanks! this pr is now ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was implementing these announcements in 5.18, because you took so long to review and merge my pull request, I forgot to complete it and add the chatlogs for them as whell like I did for the other things. But now has been fadded