fix(ci): Fix linting issues and format code

- Add noqa comments for intentional import patterns
- Format code with ruff
- Remove unused imports

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: anbeckham

src/linux_desktop_mcp/__init__.py

@@ -10,6 +10,7 @@
 def main():
     """Entry point for the MCP server."""
     from .server import main as _main
+
     _main()
 
 

src/linux_desktop_mcp/atspi_bridge.py

@@ -5,10 +5,10 @@
 """
 
 import asyncio
+import logging
 import threading
 from concurrent.futures import ThreadPoolExecutor
-from typing import Optional, Callable, Any
-import logging
+from typing import Any, Callable, Optional
 
 logger = logging.getLogger(__name__)
 
@@ -17,7 +17,8 @@
 
 try:
     import gi
-    gi.require_version('Atspi', '2.0')
+
+    gi.require_version("Atspi", "2.0")
     from gi.repository import Atspi
 
     ROLE_MAPPING = {
@@ -77,8 +78,12 @@
     Atspi = None
 
 
-from .references import (
-    ElementReference, ElementRole, ElementBounds, ElementState, ReferenceManager
+from .references import (  # noqa: E402
+    ElementBounds,
+    ElementReference,
+    ElementRole,
+    ElementState,
+    ReferenceManager,
 )
 
 
@@ -97,10 +102,10 @@ def _get_state_from_atspi(state_set) -> ElementState:
         return ElementState()
 
     return ElementState(
-        visible=state_set.contains(Atspi.StateType.VISIBLE) and
-                state_set.contains(Atspi.StateType.SHOWING),
-        enabled=state_set.contains(Atspi.StateType.ENABLED) and
-                state_set.contains(Atspi.StateType.SENSITIVE),
+        visible=state_set.contains(Atspi.StateType.VISIBLE)
+        and state_set.contains(Atspi.StateType.SHOWING),
+        enabled=state_set.contains(Atspi.StateType.ENABLED)
+        and state_set.contains(Atspi.StateType.SENSITIVE),
         focused=state_set.contains(Atspi.StateType.FOCUSED),
         selected=state_set.contains(Atspi.StateType.SELECTED),
         checked=state_set.contains(Atspi.StateType.CHECKED),
@@ -123,12 +128,7 @@ def _get_bounds_from_atspi(accessible) -> ElementBounds:
         component = accessible.get_component_iface()
         if component:
             rect = component.get_extents(Atspi.CoordType.SCREEN)
-            return ElementBounds(
-                x=rect.x,
-                y=rect.y,
-                width=rect.width,
-                height=rect.height
-            )
+            return ElementBounds(x=rect.x, y=rect.y, width=rect.width, height=rect.height)
     except Exception:
         pass
     return ElementBounds(x=0, y=0, width=0, height=0)
@@ -229,7 +229,7 @@ def _build_tree_sync(
         current_depth: int = 0,
         app_name: Optional[str] = None,
         window_title: Optional[str] = None,
-        parent_ref: Optional[str] = None
+        parent_ref: Optional[str] = None,
     ) -> list[ElementReference]:
         """Build element tree from accessible (sync)."""
         refs = []
@@ -261,7 +261,7 @@ def _build_tree_sync(
                 available_actions=_get_available_actions(accessible),
                 description=accessible.get_description() or "",
                 value=_get_element_value(accessible),
-                atspi_path=str(accessible.get_id()) if hasattr(accessible, 'get_id') else None,
+                atspi_path=str(accessible.get_id()) if hasattr(accessible, "get_id") else None,
                 atspi_accessible=accessible,
                 parent_ref=parent_ref,
                 app_name=app_name,
@@ -283,7 +283,7 @@ def _build_tree_sync(
                             current_depth=current_depth + 1,
                             app_name=app_name,
                             window_title=window_title,
-                            parent_ref=ref_id
+                            parent_ref=ref_id,
                         )
                         for child_ref in child_refs:
                             if child_ref.parent_ref == ref_id:
@@ -298,9 +298,7 @@ def _build_tree_sync(
         return refs
 
     async def build_tree(
-        self,
-        app_name_filter: Optional[str] = None,
-        max_depth: int = 15
+        self, app_name_filter: Optional[str] = None, max_depth: int = 15
     ) -> list[ElementReference]:
         """Build the full accessibility tree.
 
@@ -333,9 +331,7 @@ def _build():
         return await self._run_sync(_build)
 
     async def build_tree_for_window(
-        self,
-        window_accessible,
-        max_depth: int = 15
+        self, window_accessible, max_depth: int = 15
     ) -> list[ElementReference]:
         """Build accessibility tree for a specific window only.
 
@@ -368,7 +364,7 @@ def _build():
                     window_accessible,
                     max_depth=max_depth,
                     app_name=app_name,
-                    window_title=window_title
+                    window_title=window_title,
                 )
             except Exception as e:
                 logger.error(f"Error building tree for window: {e}")
@@ -377,9 +373,7 @@ def _build():
         return await self._run_sync(_build)
 
     async def build_tree_for_windows(
-        self,
-        window_accessibles: list,
-        max_depth: int = 15
+        self, window_accessibles: list, max_depth: int = 15
     ) -> list[ElementReference]:
         """Build accessibility tree for multiple windows.
 
@@ -411,7 +405,7 @@ def _build():
                         window_accessible,
                         max_depth=max_depth,
                         app_name=app_name,
-                        window_title=window_title
+                        window_title=window_title,
                     )
                     all_refs.extend(refs)
                 except Exception as e:
@@ -517,9 +511,7 @@ def _get_element_at_point_sync(self, x: int, y: int):
                 if app:
                     component = app.get_component_iface()
                     if component:
-                        accessible = component.get_accessible_at_point(
-                            x, y, Atspi.CoordType.SCREEN
-                        )
+                        accessible = component.get_accessible_at_point(x, y, Atspi.CoordType.SCREEN)
                         if accessible:
                             return accessible
             except Exception:

src/linux_desktop_mcp/detection.py

@@ -10,6 +10,7 @@
 
 class DisplayServer(Enum):
     """Linux display server types."""
+
     X11 = "x11"
     WAYLAND = "wayland"
     XWAYLAND = "xwayland"
@@ -19,6 +20,7 @@ class DisplayServer(Enum):
 @dataclass
 class PlatformCapabilities:
     """Available platform capabilities for desktop automation."""
+
     display_server: DisplayServer
     has_atspi: bool = False
     has_ydotool: bool = False
@@ -88,8 +90,10 @@ def _check_atspi_available() -> tuple[bool, bool]:
 
     try:
         import gi
-        gi.require_version('Atspi', '2.0')
+
+        gi.require_version("Atspi", "2.0")
         from gi.repository import Atspi
+
         pyatspi_available = True
 
         desktop = Atspi.get_desktop(0)
@@ -106,11 +110,7 @@ def _check_atspi_available() -> tuple[bool, bool]:
 def _check_ydotool_daemon() -> bool:
     """Check if ydotool daemon is running."""
     try:
-        result = subprocess.run(
-            ["pgrep", "-x", "ydotoold"],
-            capture_output=True,
-            timeout=2
-        )
+        result = subprocess.run(["pgrep", "-x", "ydotoold"], capture_output=True, timeout=2)
         return result.returncode == 0
     except (subprocess.SubprocessError, FileNotFoundError):
         return False
@@ -123,27 +123,27 @@ def _detect_compositor() -> Optional[str]:
         Compositor name (sway, hyprland, gnome, kde, etc.) or None.
     """
     # Check common compositor indicators via environment variables
-    if os.environ.get('SWAYSOCK'):
-        return 'sway'
-    if os.environ.get('HYPRLAND_INSTANCE_SIGNATURE'):
-        return 'hyprland'
-    if os.environ.get('GNOME_SETUP_DISPLAY') or os.environ.get('GNOME_SHELL_SESSION_MODE'):
-        return 'gnome'
-    if os.environ.get('KDE_FULL_SESSION') or os.environ.get('KDE_SESSION_VERSION'):
-        return 'kde'
-    if os.environ.get('WESTON_CONFIG_FILE'):
-        return 'weston'
+    if os.environ.get("SWAYSOCK"):
+        return "sway"
+    if os.environ.get("HYPRLAND_INSTANCE_SIGNATURE"):
+        return "hyprland"
+    if os.environ.get("GNOME_SETUP_DISPLAY") or os.environ.get("GNOME_SHELL_SESSION_MODE"):
+        return "gnome"
+    if os.environ.get("KDE_FULL_SESSION") or os.environ.get("KDE_SESSION_VERSION"):
+        return "kde"
+    if os.environ.get("WESTON_CONFIG_FILE"):
+        return "weston"
 
     # Try to detect via XDG_CURRENT_DESKTOP
-    desktop = os.environ.get('XDG_CURRENT_DESKTOP', '').lower()
-    if 'gnome' in desktop:
-        return 'gnome'
-    if 'kde' in desktop or 'plasma' in desktop:
-        return 'kde'
-    if 'sway' in desktop:
-        return 'sway'
-    if 'hyprland' in desktop:
-        return 'hyprland'
+    desktop = os.environ.get("XDG_CURRENT_DESKTOP", "").lower()
+    if "gnome" in desktop:
+        return "gnome"
+    if "kde" in desktop or "plasma" in desktop:
+        return "kde"
+    if "sway" in desktop:
+        return "sway"
+    if "hyprland" in desktop:
+        return "hyprland"
 
     return None
 
@@ -156,10 +156,12 @@ def _check_layer_shell_available() -> bool:
     """
     try:
         import gi
-        gi.require_version('Gtk4LayerShell', '1.0')
-        from gi.repository import Gtk4LayerShell
+
+        gi.require_version("Gtk4LayerShell", "1.0")
+        from gi.repository import Gtk4LayerShell  # noqa: F401
+
         # Note: Gtk4LayerShell.is_supported() requires GTK to be initialized
-        # So we just check if the import works
+        # So we just check if the import works (import is intentionally unused)
         return True
     except (ImportError, ValueError):
         return False
@@ -201,18 +203,12 @@ def detect_capabilities() -> PlatformCapabilities:
 
     if display_server == DisplayServer.WAYLAND:
         if not caps.has_ydotool and not caps.has_wtype:
-            caps.errors.append(
-                "No Wayland input tool available. Install ydotool or wtype."
-            )
+            caps.errors.append("No Wayland input tool available. Install ydotool or wtype.")
         elif caps.has_ydotool and not _check_ydotool_daemon():
-            caps.errors.append(
-                "ydotool daemon not running. Start with: sudo ydotoold"
-            )
+            caps.errors.append("ydotool daemon not running. Start with: sudo ydotoold")
     elif display_server == DisplayServer.X11:
         if not caps.has_xdotool and not caps.has_ydotool:
-            caps.errors.append(
-                "No X11 input tool available. Install: sudo apt install xdotool"
-            )
+            caps.errors.append("No X11 input tool available. Install: sudo apt install xdotool")
 
     return caps